Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] environment variables work only with the VITE prefix #81

Closed
matiasfha opened this issue Jan 17, 2024 · 1 comment · Fixed by #82
Closed

[Bug] environment variables work only with the VITE prefix #81

matiasfha opened this issue Jan 17, 2024 · 1 comment · Fixed by #82
Assignees
@matiasfha
Labels
released

Kommentare

@matiasfha
Copy link
Contributor

Bug Report

Describe the bug

Environment variables should be loaded using sveltekit way and default to the vite way

Is this a regression?

Steps To Reproduce the error

Expected behaviour

CodeSandbox or Live Example of Bug

Screenshot or Video Recording

Your environment

  • OS:
  • Node version:
  • Npm version:
  • Browser name and version:

Additional context
@matiasfha matiasfha self-assigned this Jan 17, 2024
@matiasfha matiasfha mentioned this issue Jan 17, 2024
Merged
12 tasks
matiasfha added a commit that referenced this issue Jan 19, 2024
@matiasfha
fix: use the dynamic env sveltekit to load the public env variables (#82
3732191 
)

# Description

Use the dynamic module to load the public env variables

## Issue Ticket Number

Fixes #81

<!-- Specify above which issue this fixes by referencing the issue
number (`#<ISSUE_NUMBER>`) or issue URL. -->
<!-- Example: Fixes
https://github.com/cloudinary-community/svelte-cloudinary/issues/<ISSUE_NUMBER>
-->

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/cloudinary-community/svelte-cloudinary/issues)
ticket for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/cloudinary-community/svelte-cloudinary/pulls)
for the same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation
github-actions bot pushed a commit that referenced this issue Jan 19, 2024
@semantic-release-bot
chore(release): 1.2.1 [skip ci]
16cc648 
## [1.2.1](v1.2.0...v1.2.1) (2024-01-19)

### Bug Fixes

* use the dynamic env sveltekit to load the public env variables ([#82](#82)) ([3732191](3732191)), closes [#81](#81)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matiasfha matiasfha

Labels
released
Projects
None yet
Milestone
No milestone
1 participant
@matiasfha