Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add video transcode feature #436

Öffnen Sie
wants to merge 6 commits into
base: master
Choose a base branch
from
Öffnen Sie

Add video transcode feature #436

wants to merge 6 commits into from
+458 −2

Conversation

adimiz1
Copy link
Contributor

@adimiz1 adimiz1 commented Jul 28, 2024

Brief Summary of Changes

Add video transcode feature

What does this PR address?

  • GitHub issue (Add reference - #XX)
  • Refactoring
  • New feature
  • Bug fix
  • Adds more tests

Are tests included?

  • Yes
  • No

Reviewer, please note:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

const-cloudinary
const-cloudinary requested changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@const-cloudinary const-cloudinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please see my comments.

Are you going to add it to the sample app?

Cloudinary/Classes/ios/Uploader/CLDVideoPreprocessChain.swift Outdated Show resolved Hide resolved
Cloudinary/Classes/ios/Uploader/CLDVideoPreprocessChain.swift Outdated Show resolved Hide resolved
Cloudinary/Classes/ios/Uploader/CLDVideoTranscode.swift Outdated Show resolved Hide resolved
Example/Tests/Preprocess/VideoPreprocessTests.swift Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@const-cloudinary const-cloudinary Awaiting requested review from const-cloudinary

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adimiz1 @const-cloudinary