[Fiber] Make DevTools Config use Static Injection #30522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't use meta programming like spread that gets deopted.
No need to have a bunch of `fieldName: null,` in the production builds.
Lets third parties specify their own version of their library separate from the reconciler.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
force-pushed
the
devtoolsinjectconfig
branch
from
bb3c784
to
4919b65
Compare
hoxyq
approved these changes
Jul 30, 2024
Comment on lines
+66
to
+70
| export const extraDevToolsConfig = { | ||
| getInspectorDataForInstance, | ||
| getInspectorDataForViewTag, | ||
| getInspectorDataForViewAtPoint, | ||
| }; |
There was a problem hiding this comment.
This will require some changes on React Native side before the sync
There was a problem hiding this comment.
Why is that? I tried to keep it the same as far as what React Native observes.
There was a problem hiding this comment.
You are right, I thought we are calling <renderer>.rendererConfig.getInspectorDataForViewAtPoint on RN side, but we actually use it from RDT global hook, so should be perfectly fine
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
We use static dependency injection. We shouldn't use this dynamic dependency injection we do for DevTools internals. There's also meta programming like spreading and stuff that isn't needed. This moves the config from `injectIntoDevTools` to the FiberConfig so it can be statically resolved. Closure Compiler has some trouble generating optimal code for this anyway so ideally we'd refactor this further but at least this is better and saves a few bytes and avoids some code paths (when minified). DiffTrain build for [146df7c](146df7c)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
We use static dependency injection. We shouldn't use this dynamic dependency injection we do for DevTools internals. There's also meta programming like spreading and stuff that isn't needed. This moves the config from `injectIntoDevTools` to the FiberConfig so it can be statically resolved. Closure Compiler has some trouble generating optimal code for this anyway so ideally we'd refactor this further but at least this is better and saves a few bytes and avoids some code paths (when minified). DiffTrain build for commit 146df7c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use static dependency injection. We shouldn't use this dynamic dependency injection we do for DevTools internals. There's also meta programming like spreading and stuff that isn't needed.
This moves the config from
injectIntoDevToolsto the FiberConfig so it can be statically resolved.Closure Compiler has some trouble generating optimal code for this anyway so ideally we'd refactor this further but at least this is better and saves a few bytes and avoids some code paths (when minified).