-
Benachrichtigungen
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix:- fixed error message of event handler message #30924
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comparing: 984ea11...8eabfbb Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
hmm.. test from react markup breaking up, need to align those test as well! |
not sure how to fix the markup tests! i tried running the same command in local, but it is not showing the same test fail stabs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please don't spam on PR,s, i have seen you spamming all over PR without any reasonable replies! |
First try to understand what 'LGTM' means |
what do you know about this PR? what makes you feel this is good to you? |
cc @sebmarkbage @eps1lon would love to know your review on this! |
The error message of
Event handlers cannot be passed to Client Component props.
seems a bit confusing as we are talking in the context of passing the same from Server components, so we should brief this error message by addingEvent handlers cannot be passed to Client Component props from Server Component