Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:- fixed error message of event handler message #30924

Öffnen Sie
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Sep 9, 2024

The error message of Event handlers cannot be passed to Client Component props. seems a bit confusing as we are talking in the context of passing the same from Server components, so we should brief this error message by adding
Event handlers cannot be passed to Client Component props from Server Component

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Vorschau Kommentare Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 3:08pm

@react-sizebot
Copy link

react-sizebot commented Sep 9, 2024

Comparing: 984ea11...8eabfbb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 505.22 kB 505.22 kB = 90.29 kB 90.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.41 kB 512.41 kB = 91.50 kB 91.50 kB
facebook-www/ReactDOM-prod.classic.js = 600.74 kB 600.74 kB = 106.27 kB 106.27 kB
facebook-www/ReactDOM-prod.modern.js = 577.03 kB 577.03 kB = 102.41 kB 102.41 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 8de1389

@Biki-das
Copy link
Contributor Author

Biki-das commented Sep 9, 2024

hmm.. test from react markup breaking up, need to align those test as well!

@Biki-das
Copy link
Contributor Author

Biki-das commented Sep 9, 2024

not sure how to fix the markup tests! i tried running the same command in local, but it is not showing the same test fail stabs!

Copy link

@anandfresh anandfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Biki-das
Copy link
Contributor Author

LGTM

Please don't spam on PR,s, i have seen you spamming all over PR without any reasonable replies!

@anandfresh
Copy link

LGTM

Please don't spam on PR,s, i have seen you spamming all over PR without any reasonable replies!

First try to understand what 'LGTM' means

@Biki-das
Copy link
Contributor Author

LGTM

Please don't spam on PR,s, i have seen you spamming all over PR without any reasonable replies!

First try to understand what 'LGTM' means

what do you know about this PR? what makes you feel this is good to you?

@Biki-das
Copy link
Contributor Author

cc @sebmarkbage @eps1lon would love to know your review on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants