Remove legacy dom node/ref stuff. #5495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimfb
force-pushed
the
remove-public-dom-instance
branch
from
add3892
to
f074de1
Compare
jimfb
force-pushed
the
remove-public-dom-instance
branch
from
f074de1
to
538d0b0
Compare
|
k |
| @@ -146,7 +146,7 @@ describe('ReactCompositeComponent', function() { | |||
| var anchor = instance.getAnchor(); | |||
| var actualDOMAnchorNode = ReactDOM.findDOMNode(anchor); | |||
There was a problem hiding this comment.
you shouldn't need ReactDOM.findDOMNode here, if I'm reading this right? IIRC since the ref is a non-composite, it should directly return the node
There was a problem hiding this comment.
Yeah, I think I agree, we don't need any of the actualDOMAnchorNode stuff. But I didn't want to confuse the diff by modifying test logic unnecessarily.
jimfb
added a commit
that referenced
this pull request
Nov 19, 2015
Remove legacy dom node/ref stuff.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove legacy dom node/ref stuff.
As per conversation with @spicyj, the only warning that appears to be firing internally is the .props access, and we think that's because of devtools (filtering out
Object.InjectedScriptresults in zero results), so I think we're good-to-go internally.