Fixes #7824

[mnpenner]

Re-submitting this PR since I messed it up. Sorry for the mess.

[facebook-github-bot]

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email [email protected] with your details so we can update your status.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[syranide]

👍 cc @jimfb (again :))

[jimfb]

For posterity, the repro is:

const React = require('react');
const ReactDOM = require('react-dom');

var Hello = React.createClass({

    getInitialState: function() {
        return {foo: "foo"};
    },

    clickA: function(ev) {
        this.setState({foo: "bar"});
    },


    render: function() {
        return <div>
            <button onClick={this.clickA}>{this.state.foo} <img src="https://s3.amazonaws.com/media-p.slid.es/uploads/alexanderfarennikov/images/1198519/reactjs.png" width="15" height="15" /></button>
        </div>;
    }
});

ReactDOM.render(
    <Hello name="World" />,
    document.getElementById('container')
);

[marvinhagemeister]

@mnpenner Thanks for your hard work in tracking this one down!

[blling]

@mnpenner do you use React15 in production, does 15.4.0 support IE8 in your experience?

[mnpenner]

@blling We're using React 15.6 in production, yes. Soon to upgrade to React 16.2 since we finally dropped IE8.

But in my experience, yes, even 15.6 worked fine with IE8.

We have a ton of polyfills though, so, that may have helped.

[blling]

@mnpenner Thanks.
Could you list the polyfills and package.json configs ( and webpack config if you use webpack ) ? :)

[mnpenner]

@blling Okay...but this is quite specific to our project, and overkill for just about anything else: https://gist.github.com/mnpenner/d09beb0c243311d2f5f512d0899114c0

[blling]

@mnpenner Could you send an email to me with the configs?
I could not open the link for some reason...

[email protected]

[blling]

cc @mnpenner , are you there？ I use webpack1.15.0 and upgrade React to 15.0.0, I get the follow error：

if (IE8_DOM_DEFINE) try {
    return dP(O, P, Attributes);
  } catch (e) { /* empty */ }
// ********************************Throws error here
if ('get' in Attributes || 'set' in Attributes) throw TypeError('Accessors not supported!') 

If i use React 0.14.9 the error is go away, do you know how could i solve the issue?

[mnpenner]

Sorry @blling, I don't know the answer. Try some more polyfills, like core-js/es6, core-js/es5 and core-js/stage/4.