-
Benachrichtigungen
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Black. Template noxfile + flake8. #6642
Conversation
crwilcox
commented
Nov 22, 2018
- Add Templating support to existing synth.py
- Refactor Synth scripts to have similar style
- Add black target and coverage to all synth.py
Cool! A bit difficult to review, though. Which files are the hand-edited ones? |
:) I tried to make it not too bad. the hand edited files are synth.py. There is some other hand-editing to mirror generation.
|
I should also note, some lint may fail right now. I am waiting until people have reviewed this to actually blacken (to avoid random noise in review) |
asset/synth.py
Outdated
# ---------------------------------------------------------------------------- | ||
# Add templated files | ||
# ---------------------------------------------------------------------------- | ||
templated_files = gcp.CommonTemplates().py_library(unit_cov_level=86, cov_level=85) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -11,3 +11,6 @@ exclude_lines = | |||
def __repr__ | |||
# Ignore abstract methods | |||
raise NotImplementedError | |||
omit = | |||
*/gapic/*.py |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -1,4 +1,5 @@ | |||
[flake8] | |||
ignore = E203, E266, E501, W503 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.