Fix default substep order when no explicit order given (#855) #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affects both going to the next and previous substep.
treitmayr
force-pushed
the
fix-default-substep-order
branch
from
2ca54af
to
e2c5eca
Compare
|
I had to update the PR because I realized that not only going to the next substep was broken, but also going to the previous one. Should work now. |
|
Thank you, @treitmayr, for your contribution! Indeed, this was a bug in the substep plugin. I have not looked in detail into its history, but maybe it was introduced by my modifications in #825 🙈 I tested your modifications and they work as expected, thank you! @henrikingo, this is good to merge :) |
janishutz
approved these changes
Mar 20, 2023
ghost
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the default order of substeps, for which no explicit order was given (see issue #855). It ensures that the loop for marking substeps "active" + "visible" is left when at least one substep (with explicit or default order) was marked and this substep uses default order.
Note: The removed space in the header of js/impress.js does not relate to the current issue, but comes from regenerating this file. Apparently the file has not been regenerated when its source file was modified in some previous commit.