JSON parsing: always fix all incoming json when using _manual_json #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
MarkJGx
changed the title
4 tasks
s106916
reviewed
Jul 17, 2024
MarkJGx
force-pushed
the
markjg/fix-json-parsing
branch
from
bb80399
to
8486380
Compare
MarkJGx
force-pushed
the
markjg/fix-json-parsing
branch
from
8486380
to
2eb3c21
Compare
- search: more aggressive cleanup path - _manual_json: Opt to fix all incoming LLM json using cheaper repair_json from json_repair before running it through the LLM repair path.
MarkJGx
force-pushed
the
markjg/fix-json-parsing
branch
from
2eb3c21
to
a375643
Compare
|
Hey. I've addressed the oversight caught in the comment and rebased on main, while rehashing the poetry lock with the new library added. Waiting for a review. @AlonsoGuevara @jgbradley1 et al. |
MarkJGx
changed the title
4 tasks
|
We have resolved several issues related to text encoding and JSON parsing that are rolled up into version 0.2.2. Please try again with that version and re-open if this is still an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change set adds non-LLM-based JSON malformity handling as a preliminary step before using the more resource-intensive LLM-based fixup.
More Details
While running GraphRAG with a local Ollama model, I noticed frequent malformed JSON responses from LLM requests, significantly slowing down the process on an M1 Max MacBook. In a fast, parallel cloud inference system, this issue is manageable, but locally it becomes a bottleneck. After indexing, I found 140 instances of JSON parsing failures.
The
json_repairlibrary effectively fixed the malformed JSON in my tests. I opted not to delve into the specific parsing failure cases, as they are mainly LLM-related and predicting every edge case is impractical. This library should be robust enough to handle most local LLM faults.Related Issues
Proposed Changes
json_repairas a new Poetry dependency.json_repairfor initial JSON repair in_manual_json, with a fallback to the LLM.Checklist