[Fabric] Introducing autocapitalize prop in TextInput - Take 2 #13343
Öffnen Sie
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielayala94
added
Area: TextInput
Area: Fabric
acoates-ms
reviewed
Jun 13, 2024
vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
Outdated
Show resolved
Hide resolved
acoates-ms
reviewed
Aug 5, 2024
vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
Outdated
Show resolved
Hide resolved
acoates-ms
reviewed
Aug 5, 2024
| }); | ||
| test('TextInputs can autocapitalize: Autocapitalize Words', async () => { | ||
|
|
||
| // Test behavior when text is set from JS - Requires change in RN Core repo to avoid override issues |
There was a problem hiding this comment.
What change is needed in RN core? Whats the issue here?
There was a problem hiding this comment.
Previously, I set defaultValues to the TextInputs featuring autocapitalization, which are declared in TextInputSharedExamples.js. Doing this caused an "override error" since that .js file is expected to be an exact copy of its parent living in RN Core. IIRC, the source of conflict was here:
\packages\@react-native\tester\overrides.json
"type": "copy",
"directory": "js/examples/TextInput",
"baseDirectory": "packages/rn-tester/js/examples/TextInput",
jonthysell
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
New feature.
Why
Enables TextInput controls to autocapitalize letters, depending on the selected mode. This PR introduces support for
characters.wordsandsentencesare out of scope, tracked in #13479.Resolves #13120
What
Introduced logic to update the TextInput during updateProps(), to enable/disable all character capitalization.
Testing
Changelog
Yes
Microsoft Reviewers: Open in CodeFlow