Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate RN Nightly 7/1 #13508

Merged
merged 47 commits into from
Aug 7, 2024
Merged

Integrate RN Nightly 7/1 #13508

merged 47 commits into from
Aug 7, 2024

Conversation

Yajur-Grover
Copy link
Contributor

@Yajur-Grover Yajur-Grover commented Jul 29, 2024

Description

Integration

What

facebook/react-native@5df5ed1...9f6cb21

Notable commits:
facebook/react-native@404f323
facebook/react-native@1830283

Notable issues:
Issue tracking reverting removal of debug feature tests: #13546
Issue to unfork new forks within ReactCommon: #13516
Future commit that resolves packages using react-native init automatically failing without warning: facebook/react-native@9aed45a
Issue tracking updates to the @react-native-community/template package (originally found in 6/18 integration): #13446

Microsoft Reviewers: Open in CodeFlow

@Yajur-Grover Yajur-Grover marked this pull request as ready for review August 7, 2024 20:49
@Yajur-Grover Yajur-Grover requested review from a team as code owners August 7, 2024 20:49
@@ -104,6 +104,7 @@ export default async function upgradeDependencies(
}),
);

console.log('\nupgrading dependencies')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this leftover debug code from the integration?

@@ -155,6 +156,7 @@ async function upgradeReactNative(
}
}

console.log('\n upgrading react-native')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above - accidentally left in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, removed both of them.

@Yajur-Grover Yajur-Grover merged commit c5dff02 into microsoft:main Aug 7, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants