Spec: Pad the payload with null contributions #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
alexmturner
added a commit
to WICG/attribution-reporting-api
that referenced
this pull request
Sep 19, 2023
Resolves #352. See also related spec change for the Private Aggregation API: patcg-individual-drafts/private-aggregation-api#98
|
@linnan-github, could you PTAL? Thanks! |
linnan-github
approved these changes
Sep 26, 2023
alexmturner
force-pushed
the
move-null-contribution-handling
branch
from
28ce9be
to
4a10aed
Compare
alexmturner
force-pushed
the
pad-payloads
branch
from
9a8bac2
to
6a210e8
Compare
Ensures that the payload always has a fixed number of contributions by adding (0,0) contributions. See #56 for more discussion.
alexmturner
force-pushed
the
pad-payloads
branch
from
6a210e8
to
b5bd90d
Compare
github-actions bot
added a commit
that referenced
this pull request
Sep 26, 2023
SHA: 813a62d Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alexmturner
added a commit
to WICG/attribution-reporting-api
that referenced
this pull request
Sep 26, 2023
Resolves #352. See also the related spec change for the Private Aggregation API: patcg-individual-drafts/private-aggregation-api#98. See also the corresponding ARA explainer change: #1031.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 28, 2023
Adds null contributions, i.e. contributions with zero value, to report payloads when serializing to ensure that the number of contributions is fixed (according to the calling API's request). This prevents the size of the encrypted payload from leaking any information about the number of contributions. This functionality is guarded behind a disabled-by-default feature and will be enabled in a separate cl. In that cl, we will update the golden report tests. See the corresponding spec changes here: WICG/attribution-reporting-api#1030 and patcg-individual-drafts/private-aggregation-api#98 Bug: 1478353 Change-Id: Ie967bbdbc6c4d9a908774a7c54ae5701c6e3d5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4887591 Commit-Queue: Alex Turner <[email protected]> Reviewed-by: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1202742}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the payload always has a fixed number of contributions by adding (0,0) contributions.
See #56 for more discussion and #95 for the corresponding spec change.
Preview | Diff