-
Benachrichtigungen
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Add tag accessibility tests page #2645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page as-is looks good. However, since we mention interactive tags on the primary tags page perhaps we should clarify we tested only non-interactive tags.
I'd change the first sentence on the page to read "Any USWDS non-interactive tag should pass these manual accessibility tests." or something along those lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I like what Amy said about changing the wording for interactive versus non-interactive. Wondering if it is worth pointing people into the direction of our slight guidance on this page as well. Or maybe not even having that phrasing so it is not open for discussion. But if we do change the phrasing maybe something, "For more guidance on interactive tag implementation, check out the tags usability section."
Changed the lead to say "Any non-interactive USWDS tag should pass these manual accessibility tests." in commit ed9e217. Let me know if you want any changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you, @amyleadem!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! One small update for the checklist lead
and the potential inclusion with another checklist item IF it doesn't delay getting this page published. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating changelog dates...
Merging over pa11y crash |
Summary
Added accessibility tests page for the tag component.
Note
The tag accessibility tests page does not include the tests for interactive tags that are included in the spreadsheet (Google sheets 🔒). This is because there is some ambiguity about the role of interactive tags in the design system and because we do not currently offer examples of interactive tags. Please confirm that the expected tests are included on this page.
Important
We should update changelog dates before merge.
Related issue
Closes #2526
Preview link
Ressourcen
Testing and review