-
Benachrichtigungen
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dynamically changing rootMargin #428
Kommentare
This seems reasonable, but also I don't think it should block whatwg/html#5510 |
Agreed. I think it doesn't need to block fixing whatwg/html#5408 either, we could temporarily violate the extensible web manifesto here. But fixing this first certainly seems nicer to me! |
I don't think there'd be an issue allowing this. |
There will be a TPAC breakout session tomorrow (30 October 14:00–15:00 UTC) to discuss this issue. https://www.w3.org/2020/10/TPAC/breakout-schedule.html#intersectionobserver |
The breakout starts in ~20 minutes. Agenda and meeting notes here: https://docs.google.com/document/d/1SXwbMiwOUkLPXSM_klk4q9mFEanbIH8IAgTM80cCMXU/edit?usp=sharing |
@zcorpan I read the meeting notes, has someone proposed an API here to allow Another use case here is top navbars that change size. |
@asakusuma The API we gravitated towards was to allow assigning to In metonym/svelte-intersection-observer#12 (comment) @dysfunc also explains a use case for this feature. The implementation in cc @chrishtr |
Part of w3c#428.
In whatwg/html#5510 I'm trying to specify
<img loading=lazy>
in terms of IntersectionObserver as per discussion in whatwg/html#5236The desired behavior for lazy-loading is to dynamically change the
rootMargin
in response to things like scrolling and network changes. See whatwg/html#5408 (comment)Since
IntersectionObserver
only allows setting therootMargin
upon initialization, this would require one ofIntersectionObserver
and observe all the same elements as the old one, and get rid of the old one. This seems bad, but I assume is what a JS polyfill would have to do?rootMargin
even though the public API doesn't allow for it.I think the second option seems better, but per the extensible web manifesto we try to have web features be explained by lower-level APIs without having special magic that isn't accessible to web developers.
Are there issues with modifying the
rootMargin
after initialization?The text was updated successfully, but these errors were encountered: