Adding in some accessibility-related language #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
previously requested changes
Jun 9, 2020
|
Lookin good, but could also use a quick tidy 🙏 |
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
|
@marcoscaceres I merged in the removed color processing steps too. |
aarongustafson
commented
Jun 10, 2020
marcoscaceres
approved these changes
Jun 18, 2020
|
Blocked on getting the A11y folk to export their definitions... |
|
@marcoscaceres I went old school on the definitions here to unblock merging this PR. Let me know if I missed anything. Respec isn’t complaining so it may be a good stopgap. |
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #860
This change (choose one):
changes normative sections without changing behavior)
Commit message:
Taking a crack at adding accessibility info. The only outstanding item is adding a recommendation for screenshot
labels once ImageResource is integrated.Preview | Diff