Do not show dialog automatically after saving a linked page

See merge request !58

Wrap the postEdit hook handler in a check for wgWikibaseItemId.

Bug: T362943

Pass sidebar link to main in postHook, rm AutosuggestSitelinkDebug flag

See merge request !56

This prevents a product error of calling `.css()` on `null`. The same
error would happen on page load if `window.AutosuggestSitelinkDebug` is
set in the user's JS, which happened to be most of the developers. This
debug mode isn't needed anymore, since we have a toolbar link to launch
the dialog.

Add header comment to compiled output

See merge request !57

This way people know how to contact us if there are issues

I don't think we can force the comment to be above the babel helpers,
but this is better than nothing. We should probably move to Rollup
or something, which would make this sort of thing easier.

Add Template namespace to validNamespaces

See merge request !55

Bug: T362758

Show new-item button at the bottom of search results

See merge request !53

Samwilson authored Apr 16, 2024 and Samtar committed Apr 16, 2024

Move the new-item button into the Dialog (and make it a ButtonWidget)
so that it can be displayed at the end of the search results as
well as when there are no search results.

Bug: T361834

Exclude Wiktionary main namespace

See merge request !54

Re-enable the toolbox link after closing dialog

See merge request !52

Wiktionary pages are rarely linked to Wikidata.

Bug: T335916

Prior to this, opening the dialog multiple times would leave the
toolbar link greyed out. To fix this, the removal of the CSS
color is moved up to the two places where we open the dialog.

The grey colour is only used as an indicator while we load the
RL modules, so isn't needed once the dialog is open.

Move items-not-found message into Dialog rather than notification

See merge request !51

Samwilson authored Apr 09, 2024 and Samtar committed Apr 09, 2024

Add a new `setMessage()` method to the Dialog class that can be
used to set the items-not-found message or the existing already-linked
message.

To make this all a bit clearer, move most of the dialog layout setup
into the `initialize()` method which now creates the message,
fieldset, and sets up the radio button listener. Each part is then
toggled to be hidden until it's actually used (i.e. by either
`setItems()` or `setMessage()` being called).

Bug: T356836

Add pending state on API calls

See merge request !49

Samwilson authored Apr 09, 2024 and HMonroy committed Apr 09, 2024

Add pushPending/popPending pairs for all API calls, as well as
a pushPending for the submit action (which doesn't need to pop
because the dialog is closed at that point).

Bug: T360184

Show 'already linked' message in Dialog rather than notification

See merge request !50

Move the 'This article is already linked to an item' message to
be shown within the dialog rather than as a separate notification
toast.

This patch also removes the API call that was being used to check
for the current page's Wikidata item, as this information is
already present within the page as wgWikibaseItemId.

Bug: T356837

Avoid loading the dialog window multiple times

See merge request !48

Samwilson authored Apr 03, 2024 and Samtar committed Apr 03, 2024

This updates the init logic to only create one instance of the
main AutosuggestSitelink object, and to move the initialization
code to a new init() method (the old init function is renamed to
main() here to avoid confusion).

Since d99574c5 the translations
are loaded in the constructor. This means that the loadTranslations()
method doesn't need to be called later, so these are removed.

Bug: T361333

Fix eslint issues and add whole src/ directory to test

See merge request !47

feat: allow the user to link a wikidata item to an article

See merge request !45

ThierryW23 authored Mar 16, 2024 and Samtar committed Mar 16, 2024

**Changes proposed so far:**

- Now, when a user click to the _AutosuggestSiteLink_ link in the Menu Tools, the dialog is immediately opened
- Now the user can select a Wikidata item and link it to an article

**Remaining change to get this task done**

- Add the loading indicator when the dialog is opened until the search results are back.

----

Bug: T360184

Upgrade to Node 18

See merge request !46

Samtar authored Mar 16, 2024 and Samwilson committed Mar 16, 2024

- Upgrade `.nvmrc` and the gitlab CI configuration to the latest possible Node version supported by our runners (v18.19.1)
- Use `ncu` to upgrade packages
- Fix the `npm run fix` command
- Use `npm run fix` to bring up to date with eslint rules
- Test and build


Bug: T360248

Keep link greyed out during loading

See merge request !44

Samwilson authored Mar 16, 2024 and Samtar committed Mar 16, 2024

Rather than only greying out the toolbox link for 3 seconds while
loading the search results etc., instead pass a $link object to
the handlers and remove the grey color only after the API calls
have been made.

This doesn't preclude also adding the loading state to the dialog
and opening that earlier, but because we need to load the OOUI
dependencies it seems like keeping a loading state on the link
is probably a good idea as well.

Bug: T360184

Rebuild

See merge request !43

Rebuild after !42

Move the AutosuggestSitelink to be under 'What links here' in the tools menu

See merge request !42

ThierryW23 authored Mar 15, 2024 and Samtar committed Mar 15, 2024

**Changes proposed:**
 - Move the AutosuggestSitelink to be under 'What links here' in the tools menu

Bug: T360185

Remove Wikisource 'Index' namespace

See merge request !41

No index namespace page should have a sitelink.

Bug: T335916

Reload after linking an item

See merge request !40

Move namespace check down, to not add sidebar link where not used

See merge request !39

Rather than re-firing the postEdit hook, reload the whole page.
This means that all dependencies in the page (scripts, modules,
templates, etc.) will be reloaded with the new Wikidata link in
place. It also avoids the error of showing two notification toasts
after closing the ASL dialog.

Bug: T340547

Check the namespace and existence earlier in the process in order
to not add the sidebar link when it's not actually able to be
used.

Bug: T347542