Page MenuHomePhabricator

Correct position & style of ImportFile edit title and edit file info buttons
Closed, ResolvedPublic

Description

pasted_file (939×751 px, 201 KB)

As can be seen in the above screenshot https://gerrit.wikimedia.org/r/#/c/344215/ introduces the button but their position needs some correcting.

For the correct position please see the mock @ T156795

Event Timeline

Addshore moved this task from Proposed to Todo on the WMDE-TechWish board.
Addshore renamed this task from Correct position of ImportFile edit title and edit file info buttons to Correct position & style of ImportFile edit title and edit file info buttons.Mar 28 2017, 5:51 PM

would it be possible to also use this ticket for changing both edit buttons to white with blue color, as is standard OOUI for secondary buttons?

would it be possible to also use this ticket for changing both edit buttons to white with blue color, as is standard OOUI for secondary buttons?

That has already been done / is included in https://gerrit.wikimedia.org/r/#/c/344215

Addshore moved this task from Todo to Proposed on the WMDE-TechWish board.

@Jan_Dittrich regarding the mock above and and the screenshot below. Did requirements change and would you approve the button layout as it is atm?

FileImport - Buttons.png (768×1 px, 162 KB)

@Charlie_WMDE did the most work on the UI, so she is probably better at asking detailed questions. It seems fine with me, I don't see any serious problems.