Log entries for global filter hits are broken if wiki goes beyond their range
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matej_suchanek
	Aug 24 2017, 7:59 AM

Description

Example - you can see nothing after "Filter description:".

Details

	Subject	Repo	Branch	Lines +/-
	Improve display of log entries when global filters are not enabled	mediawiki/extensions/AbuseFilter	master	+26 -15

Customize query in gerrit

Related Objects

Mentioned Here: T220791: afl_filter should be split in afl_filter_id and afl_global
rOMWC69def475d83a: Update dblists!

Event Timeline

matej_suchanek created this task.Aug 24 2017, 7:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2017, 7:59 AM

Apparently, cswiki has been moved to large.dblist (rOMWC69def475d83ae682a77b5aea098fc28dcc5a136f), so it doesn't have global filters enabled anymore. Still, there's the problem that older log entries do not show filter names (should they?).

Links to them are also broken.

matej_suchanek renamed this task from Global filter descriptions are not shown in AbuseLog to Log entries for global filter hits are broken if wiki goes beyond their range.Aug 26 2017, 10:26 AM

DannyS712 moved this task from Backlog to Logging on the AbuseFilter board.Oct 10 2019, 6:28 AM

We can probably show "Global filter #123" instead or always query with afl_global = 0 when T220791 is done.

In T174000#5815112, @matej_suchanek wrote:

We can probably show "Global filter #123" instead or always query with afl_global = 0 when T220791 is done.

Either shouldn't be hard to do.

Daimona edited projects, added AbuseFilter (Overhaul-2020); removed User-Daimona, AbuseFilter.Sep 16 2020, 2:04 PM

matej_suchanek moved this task from Backlog to Next on the AbuseFilter (Overhaul-2020) board.Sep 17 2020, 7:22 AM

Change 633979 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/AbuseFilter@master] Improve display of log entries when global filters are not enabled

https://gerrit.wikimedia.org/r/633979

gerritbot added a project: Patch-For-Review.Oct 14 2020, 11:37 AM

matej_suchanek claimed this task.Oct 14 2020, 11:38 AM

Change 633979 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Improve display of log entries when global filters are not enabled

https://gerrit.wikimedia.org/r/633979

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 15 2020, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 15 2020, 3:10 PM

Daimona closed this task as Resolved.Oct 15 2020, 4:26 PM

matej_suchanek moved this task from Next to Done on the AbuseFilter (Overhaul-2020) board.Jan 8 2021, 10:24 AM