| Addshore | |
| Jan 26 2018, 4:39 AM |
| F12796284: image.png | |
| Jan 26 2018, 4:39 AM |
Reproduce:
Result:
"Can't import a missing file."
Expected Result:
"Can't import file because it is actually hosted on <name of the repo, e.g. Wikimedia Commons>"?
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T140462 Correctly move files from Wikipedia to Commons (2013) | |||
| Resolved | thiemowmde | T146666 Build a commons extension that moves files to Commons | |||
| Resolved | None | T187470 Error handling in Move-Files-To-Commons | |||
| Resolved | • Lea_WMDE | T187531 Small beta Prerequisites | |||
| Invalid | None | T185734 Improve error message when importing a file that is actually on a remote repo |
So the pageInfoData is as follows:
array (size=6)
'ns' => int 6
'title' => string 'File:Ice and Snow World-Sculpture Festival 8.webm' (length=49)
'missing' => string '' (length=0)
'known' => string '' (length=0)
'imagerepository' => string 'wikimediacommons' (length=16)
'imageinfo' =>
array (size=1)
0 =>
array (size=17)
'timestamp' => string '2018-01-23T19:08:53Z' (length=20)
'user' => string 'Techyan' (length=7)
'userid' => int 0
'anon' => string '' (length=0)
'size' => int 97210846
'width' => int 1920
'height' => int 1080
'duration' => float 32.537
'comment' => string 'Videoconvert upload from toollabs' (length=33)
'canonicaltitle' => string 'File:Ice and Snow World-Sculpture Festival 8.webm' (length=49)
'thumburl' => string 'https://upload.wikimedia.org/wikipedia/commons/thumb/0/08/Ice_and_Snow_World-Sculpture_Festival_8.webm/711px--Ice_and_Snow_World-Sculpture_Festival_8.webm.jpg' (length=158)
'thumbwidth' => int 711
'thumbheight' => int 400
'url' => string 'https://upload.wikimedia.org/wikipedia/commons/0/08/Ice_and_Snow_World-Sculpture_Festival_8.webm' (length=96)
'descriptionurl' => string 'https://commons.wikimedia.org/wiki/File:Ice_and_Snow_World-Sculpture_Festival_8.webm' (length=84)
'descriptionshorturl' => string 'https://commons.wikimedia.org/w/index.php?curid=65770268' (length=56)
'sha1' => string 'a89ce83b0d579597490c7ebdc29f7d2d91a6edd7' (length=40)We can probably improve this error message to say that the file can not be imported as it comes from remote imagerepository rather than the local site.
We could also name the image repository which is listed in the imagerepository key
@Lea_WMDE I have updated the description and currently left a message of "Can't import file because it is actually hosted on a remote site"? But this message decision should probably come from you / UX
The api does give us the following:
'imagerepository' => string 'wikimediacommons' (length=16)
That we could include in the error message.
@Charlie_WMDE @Hanna_Petruschat_WMDE could you look over the error message and see if it works for you?
What credentials do you use to log in? And are all new things tested there? Because In the [wish] document it says that the test server is this one: http://mwfileimport.wmflabs.org/wiki/index.php/Special:ImportFile
So the code on master is now deployed to beta when merged so the best place to check is https://test.wikimedia.beta.wmflabs.org/wiki/Special:ImportFile
We should probably get rid of the test instance / site now.
You can just make any old account, the accounts on the beta cluster are separate to all other accounts.
Note the note on the main page, https://deployment.wikimedia.beta.wmflabs.org/wiki/Main_Page, "For security, we recommend you use a password different from your Wikimedia one."
Oki doki. I was thinking maybe we have a separate login for it like for wmflabs. Thanks!
Thanks for looking into this and the poke. These cases are indeed handled differently right now. So in any way the issue described in this ticket is invalid now.