Maniphest T193615

When a file move is started, find the correct config file for template and category mapping
Closed, ResolvedPublic
Actions

Description

Acceptance Criteria

Before the special page is displayed, find the config file for the file's source wiki
If there is no config file present, stop parsing and allow the move just like now.

Notes

Check in the CommonsHelper code base what is done to find the correct files.
Check the outcome of the investigation ticket T193614 when implementing this.

Details

Subject	Repo	Branch	Lines +/-
More consistent normalization of CommonsHelper2 config page names	mediawiki/extensions/FileImporter	master	+32 -31
Add basic happy test for CommonsHelperConfigRetriever	mediawiki/extensions/FileImporter	master	+51 -0
Extract category and template information from CommonsHelper's config files	mediawiki/extensions/FileImporter	master	+382 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T140462 Correctly move files from Wikipedia to Commons (2013)
Resolved	thiemowmde	T146666 Build a commons extension that moves files to Commons
Resolved	thiemowmde	T193614 Reuse Commonhelper2's config files for category and template matching
Resolved	Andrew-WMDE	T193615 When a file move is started, find the correct config file for template and category mapping
Declined	None	T198610 Cache API requests pulling CommonsHelper2 configuration files
Resolved	thiemowmde	T196461 Make CommonsHelper2 source wiki address configurable

Event Timeline

• Lea_WMDE triaged this task as Medium priority.May 2 2018, 10:29 AM

• Lea_WMDE created this task.

• Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Move-Files-To-Commons board.May 2 2018, 11:26 AM

thiemowmde moved this task from Incoming to Move files to Commons on the TCB-Team (now WMDE-TechWish) board.May 11 2018, 5:00 PM

thiemowmde added subscribers: thiemowmde, WMDE-Fisch, Andrew-WMDE.

Tobi_WMDE_SW updated the task description. (Show Details)May 16 2018, 10:56 AM

Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2018-05-16.

Andrew-WMDE claimed this task.May 19 2018, 3:32 PM

Tobi_WMDE_SW moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-05-16 board.May 22 2018, 11:46 AM

Change 434677 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/FileImporter@master] Extract category and template information from CommonsHelper's config files

https://gerrit.wikimedia.org/r/434677

gerritbot added a project: Patch-For-Review.May 23 2018, 11:21 AM

Andrew-WMDE mentioned this in rEFLId41284abe8c6: Extract category and template information from CommonsHelper's config files.May 23 2018, 11:27 AM

Andrew-WMDE mentioned this in rEFLIb8b92d70b264: Extract category and template information from CommonsHelper's config files.

• Lea_WMDE added a project: WMDE-QWERTY-Sprint-2018-05-23.May 23 2018, 1:17 PM

• Lea_WMDE moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-05-23 board.

• Lea_WMDE moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.May 23 2018, 1:36 PM

• Lea_WMDE changed the point value for this task from 5 to 3.May 23 2018, 1:39 PM

Andrew-WMDE mentioned this in rEFLI2a1f0529f8ac: Extract category and template information from CommonsHelper's config files.May 23 2018, 2:04 PM

Andrew-WMDE mentioned this in rEFLId9bc49a356c1: Extract category and template information from CommonsHelper's config files.May 23 2018, 2:33 PM

Andrew-WMDE mentioned this in rEFLI228419091c49: Extract category and template information from CommonsHelper's config files.May 23 2018, 4:06 PM

Andrew-WMDE mentioned this in rEFLI4ddfde423b96: Extract category and template information from CommonsHelper's config files.May 23 2018, 4:20 PM

Andrew-WMDE mentioned this in rEFLIe7135cbdf494: Extract category and template information from CommonsHelper's config files.May 30 2018, 10:48 AM

Andrew-WMDE mentioned this in rEFLI7912c585412c: Extract category and template information from CommonsHelper's config files.May 30 2018, 10:55 AM

Andrew-WMDE moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-05-23 board.May 30 2018, 10:58 AM

thiemowmde mentioned this in rEFLI41070fb7e5f3: Extract category and template information from CommonsHelper's config files.Jun 4 2018, 10:00 AM

Change 437289 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Add basic happy test for CommonsHelperConfigRetriever

https://gerrit.wikimedia.org/r/437289

thiemowmde mentioned this in rEFLI5b62d5098c84: Add basic happy test for CommonsHelperConfigRetriever.Jun 4 2018, 4:51 PM

Change 437419 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] [WIP] Mark code that needs to be worked on with FIXMEs

https://gerrit.wikimedia.org/r/437419

thiemowmde mentioned this in rEFLIa9a851aa4231: [WIP] Mark code that needs to be worked on with FIXMEs.Jun 5 2018, 9:17 AM

Change 434677 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Extract category and template information from CommonsHelper's config files

https://gerrit.wikimedia.org/r/434677

Change 437289 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add basic happy test for CommonsHelperConfigRetriever

https://gerrit.wikimedia.org/r/437289

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 5 2018, 11:00 AM

WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-05-23 board.Jun 5 2018, 11:33 AM

Change 439555 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] More consistent normalization of CommonsHelper2 config page names

https://gerrit.wikimedia.org/r/439555

thiemowmde added a project: WMDE-QWERTY-Sprint-2018-06-05.Jun 11 2018, 9:32 AM

thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-06-05 board.

To tests: I configured https://mwfileimport.wmflabs.org/wiki/index.php/Special:ImportFile so it can be used with the CommonsHelper2 config files.

Change 439555 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] More consistent normalization of CommonsHelper2 config page names

https://gerrit.wikimedia.org/r/439555

thiemowmde moved this task from Review to Done on the WMDE-QWERTY-Sprint-2018-06-05 board.Jun 11 2018, 4:50 PM

thiemowmde removed a project: Patch-For-Review.Jun 11 2018, 4:52 PM

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)); removed MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 11 2018, 5:00 PM

• Vvjjkkii renamed this task from When a file move is started, find the correct config file for template and category mapping to 4sdaaaaaaa.Jul 1 2018, 1:12 AM

• Vvjjkkii removed Andrew-WMDE as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail.

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

• Vvjjkkii removed a subscriber: gerritbot.

Bodhisattwa renamed this task from 4sdaaaaaaa to When a file move is started, find the correct config file for template and category mapping.Jul 1 2018, 1:28 PM

Bodhisattwa assigned this task to Andrew-WMDE.

Bodhisattwa lowered the priority of this task from High to Medium.