Page MenuHomePhabricator
Create Task
Maniphest T216625

Test proof of concept for "media" search
Closed, ResolvedPublic
Actions

Assigned To
None
Authored By
• PDrouin-WMF
Feb 20 2019, 3:29 PM
Tags
Referenced Files
F31808574: Screen Shot 2020-05-08 at 4.37.52 PM.png
May 8 2020, 11:39 PM
F31808563: Screen Shot 2020-05-08 at 4.16.02 PM.png
May 8 2020, 11:39 PM
F31808561: Screen Shot 2020-05-08 at 4.15.48 PM.png
May 8 2020, 11:39 PM
F31808570: Screen Shot 2020-05-08 at 4.12.01 PM.png
May 8 2020, 11:39 PM
F31808568: Screen Shot 2020-05-08 at 3.47.21 PM.png
May 8 2020, 11:39 PM
Subscribers
Abit
Aklapper
CBogen
dcausse
EBernhardson
Etonkovidova
Nathank2
View All 9 Subscribers

Description

In preparation for a possible new search results interface on Commons, we need to put existing proof of concept/experimental code onto production Commons for testing with live Wikibase Federation and Wikidata data.

Acceptance criteria:

  • Create a new extension accessible by a hidden special page on Commons
  • Restrict access to logged-in users who are on a whitelist maintained by the team

Goals:

  • Define a Protocol for testing
  • Gather Results of tests
  • Gather/define Recommendations

COVID-19 Deployment Criteria

  • Can you roll back this change without lasting impact?
    1. A recovery plan is required as this will help identify our capacity for recovering from the failure
    2. THIS IS A KEY QUESTION, if you can’t answer it, you shouldn’t deploy
  • Is specialized knowledge required to support this change in production? If so, are there multiple people with this knowledge?
  • Is there a way to increase confidence about the correctness of this change?
    1. Reviews (Design, Code, etc)
    2. Testing coverage (unit tests, integration tests)
    3. Manual testing (e.g. Beta, vagrant, docker)

Details

SubjectRepoBranchLines +/-
Remove text & metadata and optimize gridmediawiki/extensions/WikibaseMediaInfomaster+87 -177
Refine mediasearchmediawiki/extensions/WikibaseMediaInfomaster+105 -79
Optimize media searchmediawiki/extensions/WikibaseMediaInfomaster+15 -11
Improved media-specific searchmediawiki/extensions/WikibaseMediaInfomaster+1 K -4
Customize query in gerrit

Related Objects

Event Timeline

• PDrouin-WMF created this task.Feb 20 2019, 3:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2019, 3:29 PM
• PDrouin-WMF added a comment.Feb 20 2019, 3:30 PM
This comment was removed by • PDrouin-WMF.
• PDrouin-WMF updated the task description. (Show Details)Feb 20 2019, 3:31 PM
Aklapper added a project: Structured-Data-Design.Aug 10 2019, 11:59 PM
MBinder_WMF moved this task from Backlog 📚 to Next up 📓 on the Structured-Data-Design board.Aug 12 2019, 3:05 PM
• PDrouin-WMF moved this task from Next up 📓 to Backlog 📚 on the Structured-Data-Design board.Oct 3 2019, 8:34 PM
Aklapper added a comment.Mar 18 2020, 6:03 PM

(Adding Structured-Data-Backlog project tag as SDC Design / Structured-Data-Design project tags have been archived, and as tasks need to have an active project tag associated so they can be found on a project workboard. Not sure whether to also add Design.)

Aklapper added a project: Structured-Data-Backlog.Mar 23 2020, 7:53 AM
• Ramsey-WMF edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog, Structured-Data-Design, SDC Design.Mar 24 2020, 9:49 PM
• Ramsey-WMF subscribed.

Repurposing this old ticket for the new work.

• Ramsey-WMF renamed this task from Test proof of concept for search to Test proof of concept for "media" search.Mar 24 2020, 9:53 PM
• Ramsey-WMF updated the task description. (Show Details)
• Ramsey-WMF removed a subscriber: • PDrouin-WMF.
gerritbot added a comment.Mar 25 2020, 2:01 PM

Change 563106 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Improved media-specific search

https://gerrit.wikimedia.org/r/563106

gerritbot added a project: Patch-For-Review.Mar 25 2020, 2:01 PM
matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Mar 25 2020, 2:01 PM
CBogen updated the task description. (Show Details)Mar 25 2020, 6:29 PM
CBogen mentioned this in T246792: Performance review of Improved Commons Search.Mar 30 2020, 7:54 PM
gerritbot added a comment.Apr 2 2020, 7:59 AM

Change 563106 merged by Matthias Mullie:
[mediawiki/extensions/WikibaseMediaInfo@master] Improved media-specific search

https://gerrit.wikimedia.org/r/563106

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 2 2020, 8:04 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 2 2020, 8:10 AM
• Ramsey-WMF moved this task from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.Apr 2 2020, 7:19 PM
gerritbot added a comment.Apr 10 2020, 1:14 PM

Change 587993 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Refine mediasearch

https://gerrit.wikimedia.org/r/587993

gerritbot added a project: Patch-For-Review.Apr 10 2020, 1:14 PM
CBogen moved this task from Verify on Production to Code Review on the Structured-Data-Backlog (Current Work) board.Apr 10 2020, 1:44 PM
gerritbot added a comment.Apr 16 2020, 3:04 PM

Change 589326 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Optimize media search

https://gerrit.wikimedia.org/r/589326

gerritbot added a comment.Apr 17 2020, 3:43 PM

Change 589625 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove text & metadata and optimize grid

https://gerrit.wikimedia.org/r/589625

gerritbot added a comment.Apr 28 2020, 12:02 PM

Change 587993 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Refine mediasearch

https://gerrit.wikimedia.org/r/587993

gerritbot added a comment.Apr 28 2020, 12:03 PM

Change 589326 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Optimize media search

https://gerrit.wikimedia.org/r/589326

gerritbot added a comment.Apr 28 2020, 12:03 PM

Change 589625 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove text & metadata and optimize grid

https://gerrit.wikimedia.org/r/589625

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2020, 12:10 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 28 2020, 1:00 PM
CBogen moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Apr 28 2020, 6:23 PM
Etonkovidova subscribed.May 8 2020, 11:39 PM

Manual testing (e.g. Beta, vagrant, docker)

(0) none of my test users belongs to Media search testers on production wikis, I tested it in betalabs.
(1) Betalbs displays an issue with repeated images: if there is only few results returned in the search - the image will be repeated.

Search for "kitty"

normal searchmedia search
Screen Shot 2020-05-08 at 4.15.48 PM.png (391×1 px, 127 KB)
Screen Shot 2020-05-08 at 4.16.02 PM.png (466×1 px, 287 KB)

When the search returns only one image (e.g. search criteria "flower rose") - MediaSearch will still repeat the image:

Screen Shot 2020-05-08 at 3.47.21 PM.png (593×1 px, 371 KB)

(2) Often the images are not uniformly tiled :
search "tree"
Screen Shot 2020-05-08 at 4.12.01 PM.png (684×1 px, 1 MB)

vs
Screen Shot 2020-05-08 at 4.37.52 PM.png (614×1 px, 204 KB)

CBogen subscribed.May 11 2020, 2:03 PM

@Etonkovidova if you give us your test usernames, we can add them to the whitelist so you can test in production.

Etonkovidova added a comment.May 12 2020, 4:03 PM
In T216625#6124880, @CBogen wrote:

@Etonkovidova if you give us your test usernames, we can add them to the whitelist so you can test in production.

Thanks! Zilant17 is my test user name in production.

CBogen added a comment.Jun 8 2020, 4:32 PM

Closing because the initial prototype is up and working. Further improvements have their own tickets.

CBogen closed this task as Resolved.Jun 8 2020, 4:33 PM
CBogen merged a task: T216645: commons "ideal" search.Jul 30 2020, 7:56 PM
CBogen added subscribers: EBernhardson, Nathank2, Abit and 2 others.
Krinkle mentioned this in T10738: Improve media (image) search display.Aug 10 2022, 3:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits