Page MenuHomePhabricator
Create Task
Maniphest T220191

Remove calls to deprecated methods in Title and User with calls to the new PermissionManager service.
Closed, DeclinedPublic3 Estimated Story Points
Actions

Description

The methods deprecated in T208768: Create a PermissionManager service and T218558: Move User::getRights and related methods into PermissionManager should no longer be called in MediaWiki core. Calling code should use the methods in the new PermissionManager service instead.

In service classes that are already managed by MediaWikiServices or use a static singleton, a PermissionManager instance should be injected into the constructor. Other classes can use the global MediaWikiServices instance as a service locator to access a PermissionManager instance.

Details

SubjectRepoBranchLines +/-
Replace deprecated User::isAllowed with PermissionManagermediawiki/extensions/CheckUsermaster+18 -7
Replace deprecated User::isAllowed with PermissionManagermediawiki/extensions/Echomaster+7 -4
Hard-deprecate User::getAllRightsmediawiki/coremaster+1 -0
Hard deprecate User::isEveryoneAllowedmediawiki/coremaster+8 -8
Remove usages of deprecated User methodsmediawiki/extensions/AbuseFiltermaster+66 -40
Remove usages of deprecated User methodsmediawiki/extensions/CentralAuthmaster+75 -30
Remove usages of deprecated User methods.mediawiki/extensions/FlaggedRevsmaster+134 -53
Remove usage of deprecated User methods.mediawiki/extensions/EntitySchemamaster+19 -10
Replace deprecated User::isAllowed.mediawiki/extensions/GlobalPreferencesmaster+2 -2
DefaultPreferencesFactory: Remove fallback for null PermissionManagermediawiki/coremaster+2 -7
Provide PermissionManager to PreferencesFactory constructor.mediawiki/extensions/GlobalPreferencesmaster+12 -6
Make WatchedItemQueryService depend on PermissionManagermediawiki/coremaster+50 -35
Remove usages of deprecated User methods.mediawiki/extensions/WikibaseLexememaster+60 -17
Make DefaultPreferencesFactory depend on PermissionManager.mediawiki/coremaster+80 -51
Replace usages of deprecated User::isAllowed. Step 2.mediawiki/coremaster+497 -212
Remove usage of deprecated User methods.mediawiki/extensions/Wikibasemaster+208 -81
Remove obvious usages of deprecated methods in User,Title,Revision.mediawiki/extensions/Flowmaster+79 -41
Move User::getAllRights to PermissionManager.mediawiki/coremaster+24 -7
Deprecate and replace usages of User:isAllowed{All,Any}mediawiki/coremaster+161 -57
Remove deprecated User groups/permission static calls.mediawiki/coremaster+57 -28
[Tests] Don't mock deprecated User::isAllowed for testing.mediawiki/extensions/Wikibasemaster+10 -5
Remove usages of deprecated User::getRights.mediawiki/coremaster+18 -9
Replace User::isAllowed with PermissionManager.mediawiki/coremaster+223 -144
Migrate remaining usages of Title::userCan() to PermissionManagermediawiki/coremaster+105 -28
API: Migrate Title::userCan() calls to PermissionManagermediawiki/coremaster+65 -14
EditPage: Migrate Title::userCan() calls to PermissionManagermediawiki/coremaster+101 -18
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
WDoranWMF added a project: Platform Team Workboards (Doing).May 28 2019, 7:20 PM

@daniel will review to check if this sub tasks are accurate

  • Quantity of calls is an unknown
    • We may also wish to investigate how to inject this
daniel closed subtask T223294: Deprecate the $mRights field in the User class, replacing it with a cache in PermissionManager. as Resolved.May 29 2019, 7:23 PM
daniel closed subtask T218558: Move User::getRights and related methods into PermissionManager as Resolved.
kostajh reopened subtask T218558: Move User::getRights and related methods into PermissionManager as Open.May 30 2019, 2:13 PM
kostajh reopened subtask T223294: Deprecate the $mRights field in the User class, replacing it with a cache in PermissionManager. as Open.
gerritbot added a comment.Jun 3 2019, 8:56 AM

Change 511068 merged by jenkins-bot:
[mediawiki/core@master] API: Migrate Title::userCan() calls to PermissionManager

https://gerrit.wikimedia.org/r/511068

Maintenance_bot removed a project: Patch-For-Review.Jun 3 2019, 9:10 AM
gerritbot added a comment.Jun 3 2019, 10:49 AM

Change 513974 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] Migrate remaining usages of Title::userCan() to PermissionManager

https://gerrit.wikimedia.org/r/513974

gerritbot added a project: Patch-For-Review.Jun 3 2019, 10:49 AM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.8; 2019-06-04); removed MW-1.34-notes (1.34.0-wmf.7; 2019-05-28).Jun 3 2019, 1:00 PM
WDoranWMF edited projects, added Platform Team Workboards (Team 3); removed Platform Team Workboards (Doing), Platform Team Legacy (Next).Jun 10 2019, 3:13 PM
WDoranWMF moved this task from Backlog to Ready on the Platform Team Workboards (Team 3) board.
gerritbot added a comment.Jun 14 2019, 11:19 AM

Change 513974 merged by jenkins-bot:
[mediawiki/core@master] Migrate remaining usages of Title::userCan() to PermissionManager

https://gerrit.wikimedia.org/r/513974

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.10; 2019-06-18); removed MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).Jun 14 2019, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 14 2019, 12:10 PM
daniel closed subtask T218558: Move User::getRights and related methods into PermissionManager as Resolved.Jul 1 2019, 10:09 AM
CCicalese_WMF moved this task from Ready to Backlog on the Platform Team Workboards (Team 3) board.Jul 1 2019, 2:55 PM
WDoranWMF moved this task from Backlog to mop on the Platform Team Workboards (Team 3) board.Jul 17 2019, 4:45 PM
WDoranWMF removed a project: Platform Team Workboards (Team 3).
WDoranWMF moved this task from Decoupling (CDP2) to mop on the Platform Engineering board.Jul 26 2019, 6:55 PM
WDoranWMF edited projects, added Core Platform Team Initiatives (Decoupling (CDP2)); removed Platform Engineering (Decoupling (CDP2)).
gerritbot added a comment.Aug 16 2019, 10:23 PM

Change 530623 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] WIP: Replace User::isAllowed with PermissionManager.

https://gerrit.wikimedia.org/r/530623

gerritbot added a project: Patch-For-Review.Aug 16 2019, 10:23 PM
gerritbot added a comment.Aug 21 2019, 2:22 AM

Change 531329 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Remove usages of deprecated User::getRights.

https://gerrit.wikimedia.org/r/531329

gerritbot added a comment.Aug 21 2019, 8:00 AM

Change 530623 merged by jenkins-bot:
[mediawiki/core@master] Replace User::isAllowed with PermissionManager.

https://gerrit.wikimedia.org/r/530623

gerritbot added a comment.Aug 21 2019, 8:15 AM

Change 531329 merged by jenkins-bot:
[mediawiki/core@master] Remove usages of deprecated User::getRights.

https://gerrit.wikimedia.org/r/531329

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.20; 2019-08-27); removed MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Aug 21 2019, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 21 2019, 9:10 AM
gerritbot added a comment.Aug 21 2019, 2:34 PM

Change 531503 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Replace usages of deprecated User::getRights. Step 2.

https://gerrit.wikimedia.org/r/531503

gerritbot added a project: Patch-For-Review.Aug 21 2019, 2:34 PM
gerritbot added a comment.Aug 21 2019, 4:59 PM

Change 531529 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/Wikibase@master] [Tests] Don't mock deprecated User::isAllowed for testing.

https://gerrit.wikimedia.org/r/531529

gerritbot added a comment.Aug 21 2019, 7:38 PM

Change 531529 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] [Tests] Don't mock deprecated User::isAllowed for testing.

https://gerrit.wikimedia.org/r/531529

gerritbot added a comment.Aug 21 2019, 10:43 PM

Change 531575 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] WIP: Deprecate and replace usages of User:isAllowed{All,Any}

https://gerrit.wikimedia.org/r/531575

gerritbot added a comment.Aug 22 2019, 2:23 AM

Change 531590 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Remove deprecated User::getGroupPermissions calls.

https://gerrit.wikimedia.org/r/531590

gerritbot added a comment.Aug 22 2019, 10:58 AM

Change 531590 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated User groups/permission static calls.

https://gerrit.wikimedia.org/r/531590

gerritbot added a comment.Aug 22 2019, 5:31 PM

Change 531575 merged by Ppchelko:
[mediawiki/core@master] Deprecate and replace usages of User:isAllowed{All,Any}

https://gerrit.wikimedia.org/r/531575

gerritbot added a comment.Aug 22 2019, 10:54 PM

Change 531761 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Make DefaultPreferencesFactory depend on PermissionManager.

https://gerrit.wikimedia.org/r/531761

gerritbot added a comment.Aug 23 2019, 1:04 AM

Change 531772 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/GlobalPreferences@master] Provide PermissionManager to PreferencesFactory constructor.

https://gerrit.wikimedia.org/r/531772

gerritbot added a comment.Aug 24 2019, 12:58 AM

Change 531995 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/Wikibase@master] Remove deprecated User methods.

https://gerrit.wikimedia.org/r/531995

• Pchelolo added a project: Platform Team Workboards (Clinic Duty Team).Aug 26 2019, 10:21 PM
• Pchelolo moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.
gerritbot added a comment.Aug 26 2019, 11:37 PM

Change 532486 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Move User::getAll{Rights,Groups} to PermissionManager.

https://gerrit.wikimedia.org/r/532486

• mobrovac moved this task from Waiting for Review to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Aug 28 2019, 1:16 PM
daniel reassigned this task from daniel to • Pchelolo.Aug 29 2019, 4:24 PM
daniel moved this task from Ready (WIP:5) to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.
gerritbot added a comment.Aug 29 2019, 9:00 PM

Change 532486 merged by jenkins-bot:
[mediawiki/core@master] Move User::getAllRights to PermissionManager.

https://gerrit.wikimedia.org/r/532486

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.21; 2019-09-03); removed MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 29 2019, 10:00 PM
CCicalese_WMF closed subtask T223294: Deprecate the $mRights field in the User class, replacing it with a cache in PermissionManager. as Resolved.Sep 3 2019, 3:23 PM
gerritbot added a comment.Sep 4 2019, 12:37 AM

Change 534258 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/Flow@master] Remove obvious usages of deprecated methods in User,Title,Revision.

https://gerrit.wikimedia.org/r/534258

gerritbot added a comment.Sep 4 2019, 10:01 PM

Change 534258 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Remove obvious usages of deprecated methods in User,Title,Revision.

https://gerrit.wikimedia.org/r/534258

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.22; 2019-09-10); removed MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 4 2019, 11:01 PM
gerritbot added a comment.Sep 6 2019, 1:27 PM

Change 531995 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove usage of deprecated User methods.

https://gerrit.wikimedia.org/r/531995

gerritbot added a comment.Sep 12 2019, 12:33 PM

Change 531503 merged by jenkins-bot:
[mediawiki/core@master] Replace usages of deprecated User::isAllowed. Step 2.

https://gerrit.wikimedia.org/r/531503

Lucas_Werkmeister_WMDE mentioned this in T232748: Several tests in Wikibase CI failing with “Invalid argument supplied for foreach()” in PermissionManager.Sep 12 2019, 2:21 PM
gerritbot added a comment.Sep 12 2019, 4:58 PM

Change 536235 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/WikibaseLexeme@master] Remove usages of deprecated User methods.

https://gerrit.wikimedia.org/r/536235

gerritbot added a comment.Sep 12 2019, 9:03 PM

Change 531761 merged by jenkins-bot:
[mediawiki/core@master] Make DefaultPreferencesFactory depend on PermissionManager.

https://gerrit.wikimedia.org/r/531761

gerritbot added a comment.Sep 12 2019, 9:10 PM

Change 536353 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] DefaultPreferencesManager: Remove fallback for null PermissionManager

https://gerrit.wikimedia.org/r/536353

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.23; 2019-09-17); removed MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 12 2019, 10:00 PM
gerritbot added a comment.Sep 13 2019, 11:32 AM

Change 536235 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove usages of deprecated User methods.

https://gerrit.wikimedia.org/r/536235

gerritbot added a comment.Sep 13 2019, 8:44 PM

Change 536685 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Make WatchedItemQueryService depend on PermissionManager

https://gerrit.wikimedia.org/r/536685

WDoranWMF moved this task from Doing(WIP:5) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Sep 16 2019, 1:53 PM
gerritbot added a comment.Sep 17 2019, 10:11 AM

Change 536685 merged by jenkins-bot:
[mediawiki/core@master] Make WatchedItemQueryService depend on PermissionManager

https://gerrit.wikimedia.org/r/536685

• mobrovac moved this task from Waiting for Review to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Sep 17 2019, 12:34 PM
gerritbot added a comment.Sep 17 2019, 8:30 PM

Change 531772 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Provide PermissionManager to PreferencesFactory constructor.

https://gerrit.wikimedia.org/r/531772

gerritbot added a comment.Sep 17 2019, 8:32 PM

Change 536353 merged by jenkins-bot:
[mediawiki/core@master] DefaultPreferencesFactory: Remove fallback for null PermissionManager

https://gerrit.wikimedia.org/r/536353

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.24; 2019-09-24); removed MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 17 2019, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 17 2019, 9:10 PM
gerritbot added a comment.Sep 18 2019, 9:18 PM

Change 537758 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/GlobalPreferences@master] Replace deprecated User::isAllowed.

https://gerrit.wikimedia.org/r/537758

gerritbot added a project: Patch-For-Review.Sep 18 2019, 9:19 PM
gerritbot added a comment.Sep 18 2019, 9:49 PM

Change 537766 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/AbuseFilter@master] Remove usages of deprecated User methods

https://gerrit.wikimedia.org/r/537766

gerritbot added a comment.Sep 19 2019, 7:34 AM

Change 537758 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Replace deprecated User::isAllowed.

https://gerrit.wikimedia.org/r/537758

gerritbot added a comment.Sep 26 2019, 9:07 PM

Change 539416 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/EntitySchema@master] Remove usage of deprecated User methods.

https://gerrit.wikimedia.org/r/539416

gerritbot added a comment.Sep 27 2019, 10:13 AM

Change 539416 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Remove usage of deprecated User methods.

https://gerrit.wikimedia.org/r/539416

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.25; 2019-10-01); removed MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 27 2019, 11:00 AM
daniel triaged this task as Low priority.Sep 30 2019, 2:57 PM
gerritbot added a comment.Oct 4 2019, 7:26 PM

Change 540951 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/FlaggedRevs@master] Remove usages of deprecated User methods.

https://gerrit.wikimedia.org/r/540951

gerritbot added a comment.Oct 7 2019, 8:11 PM

Change 540951 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Remove usages of deprecated User methods.

https://gerrit.wikimedia.org/r/540951

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 7 2019, 9:00 PM
WDoranWMF moved this task from Ready (WIP:5) to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Oct 23 2019, 8:47 PM
gerritbot added a comment.Oct 30 2019, 2:11 AM

Change 547064 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Hard deprecate User::isEveryoneAllowed

https://gerrit.wikimedia.org/r/547064

gerritbot added a comment.Oct 30 2019, 2:30 AM

Change 547065 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/CentralAuth@master] Remove usages of deprecated User methods

https://gerrit.wikimedia.org/r/547065

gerritbot added a comment.Oct 30 2019, 2:38 AM

Change 547066 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Hard-deprecate User::getAllRights

https://gerrit.wikimedia.org/r/547066

gerritbot added a comment.Oct 30 2019, 11:28 AM

Change 547065 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Remove usages of deprecated User methods

https://gerrit.wikimedia.org/r/547065

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.5; 2019-11-05); removed MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 30 2019, 12:00 PM
gerritbot added a comment.Oct 30 2019, 6:46 PM

Change 537766 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove usages of deprecated User methods

https://gerrit.wikimedia.org/r/537766

gerritbot added a comment.Oct 31 2019, 6:32 PM

Change 547064 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate User::isEveryoneAllowed

https://gerrit.wikimedia.org/r/547064

gerritbot added a comment.Nov 1 2019, 1:43 AM

Change 547066 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate User::getAllRights

https://gerrit.wikimedia.org/r/547066

Maintenance_bot removed a project: Patch-For-Review.Nov 1 2019, 2:10 AM
gerritbot added a comment.Mar 5 2020, 7:38 PM

Change 577330 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/CheckUser@master] Replace deprecated User::isAllowed with PermissionManager

https://gerrit.wikimedia.org/r/577330

gerritbot added a project: Patch-For-Review.Mar 5 2020, 7:38 PM
gerritbot added a comment.Mar 6 2020, 11:22 AM

Change 577537 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Echo@master] Replace deprecated User::isAllowed with PermissionManager

https://gerrit.wikimedia.org/r/577537

• Pchelolo edited projects, added Technical-Debt (Deprecation process); removed Patch-For-Review, Platform Team Workboards (Clinic Duty Team).Mar 24 2020, 8:49 PM
gerritbot added a comment.Mar 24 2020, 9:00 PM

Change 577537 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Replace deprecated User::isAllowed with PermissionManager

https://gerrit.wikimedia.org/r/577537

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.26; 2020-03-31); removed MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Mar 24 2020, 9:00 PM
gerritbot added a comment.Aug 24 2020, 5:19 PM

Change 577330 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Replace deprecated User::isAllowed with PermissionManager

https://gerrit.wikimedia.org/r/577330

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 24 2020, 6:00 PM
• Pchelolo closed this task as Declined.Jun 17 2021, 10:50 PM
daniel closed subtask T223295: Make PermissionManager aware of the current user's session. as Declined.Jul 2 2021, 12:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits