Termbox: Use "vue" ResourceLoader module from core
Closed, ResolvedPublic
Actions

Description

vue is available as a ResourceLoader module from core (previously in wikibase only).
If the dependency to vue is externalized in termbox, the payload that needs to be shipped to clients can be reduced which helps loading time and bandwidth consumption (assuming the same client made use of another vue-based frontend component before).

Details

Subject	Repo	Branch	Lines +/-
Update termbox pin to latest master	mediawiki/extensions/Wikibase	master	+1 -1
Build client-side for lib target commonjs	wikibase/termbox	master	+3 -5
Termbox: Use "vue" ResourceLoader module from core	wikibase/termbox	master	+17 -11
Termbox: Use "vue" ResourceLoader module from core	mediawiki/extensions/Wikibase	master	+2 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		guergana.tzatchkova	T247520 Use "vue" ResourceLoader module from core
		Resolved		Jakob_WMDE	T228528 Termbox: Use "vue" ResourceLoader module from core

Event Timeline

• Pablo-WMDE created this task.Jul 19 2019, 3:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2019, 3:57 PM

• Pablo-WMDE updated the task description. (Show Details)Jul 19 2019, 4:04 PM

WMDE-leszek subscribed.Jul 24 2019, 8:26 AM

• Pablo-WMDE mentioned this in T228857: Step 1: minification of common.js (formerly: Investigate common.js bundle content/size).Jul 24 2019, 11:52 AM

• Pablo-WMDE mentioned this in T227179: Investigate whether we can use OOUI overlays with Vue contents.Sep 24 2019, 3:37 PM

Jakob_WMDE mentioned this in rWBTB5f6538b4ac38: vue: update to v2.6.11.Dec 20 2019, 3:02 PM

• Pablo-WMDE updated the task description. (Show Details)Feb 12 2020, 4:55 PM

• Pablo-WMDE added a project: [DEPRECATED] wdwb-tech.Mar 12 2020, 2:33 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptMar 12 2020, 2:33 PM

• Pablo-WMDE renamed this task from Use externalized vue to Termbox: Use "vue" ResourceLoader module from core.Mar 12 2020, 2:42 PM

• Pablo-WMDE added a parent task: T247520: Use "vue" ResourceLoader module from core.

guergana.tzatchkova claimed this task.Jul 2 2020, 9:54 AM

guergana.tzatchkova added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jul 2 2020, 10:15 AM

guergana.tzatchkova moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 7 2020, 5:04 PM

Change 610715 had a related patch set uploaded (by Guergana Tzatchkova; owner: Guergana Tzatchkova):
[wikibase/termbox@master] Termbox: Use "vue" ResourceLoader module from core

https://gerrit.wikimedia.org/r/610715

gerritbot added a project: Patch-For-Review.Jul 9 2020, 8:59 AM

Change 610749 had a related patch set uploaded (by Guergana Tzatchkova; owner: Guergana Tzatchkova):
[mediawiki/extensions/Wikibase@master] Termbox: Use "vue" ResourceLoader module from core

https://gerrit.wikimedia.org/r/610749

guergana.tzatchkova moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 9 2020, 1:16 PM

guergana.tzatchkova moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 15 2020, 11:18 AM

guergana.tzatchkova moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 610749 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Termbox: Use "vue" ResourceLoader module from core

https://gerrit.wikimedia.org/r/610749

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 15 2020, 5:00 PM

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 15 2020, 8:45 PM

Change 610715 merged by Guergana Tzatchkova:
[wikibase/termbox@master] Termbox: Use "vue" ResourceLoader module from core

https://gerrit.wikimedia.org/r/610715

guergana.tzatchkova mentioned this in rWBTB9e4ede74fb14: Termbox: Use "vue" ResourceLoader module from core.Jul 16 2020, 8:35 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2020, 9:10 AM

✅

Reopening this ticket, as it seems incomplete and not working as intended.

The termbox submodule pin in Wikibase wasn't updated. Production is now running an old termbox version from March that lists Vue as a dependency, but doesn't actually have it externalized.
Even with the pin updated, the latest version doesn't seem to work in integration with Wikibase. Unless I'm doing something wrong, it seems that for termbox it isn't as easy as telling the build config to externalize the library. Termbox isn't yet following the init/app split as bridge or tainted references, so it may not know that it needs to require (commonjs) Vue.

I stumbled across this because I was trying to improve the termbox browser test after running into issues on a completely unrelated change. Current termbox master does not work in integration with Wikibase. As far as I know there aren't any user-facing changes in the making for termbox, but a broken master branch is not good. This needs to be looked into.

Jakob_WMDE claimed this task.Sep 18 2020, 2:26 PM

Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 628347 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Build client-side for lib target commonjs

https://gerrit.wikimedia.org/r/628347

gerritbot added a project: Patch-For-Review.Sep 18 2020, 2:57 PM

Lucas_Werkmeister_WMDE subscribed.Sep 18 2020, 4:00 PM

Change 628347 merged by jenkins-bot:
[wikibase/termbox@master] Build client-side for lib target commonjs

https://gerrit.wikimedia.org/r/628347

Jakob_WMDE mentioned this in rWBTBa5f18ade2c97: Build client-side for lib target commonjs.Sep 19 2020, 1:25 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2020, 2:10 AM

Change 628744 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Update termbox pin to latest master

https://gerrit.wikimedia.org/r/628744