Page MenuHomePhabricator
Create Task
Maniphest T235003

Clean up naming conflicts around writing secondary schema data for Jade
Closed, ResolvedPublic
Actions

Description

  • ProposalLinkTable
    • should be EntityLinkTable
  • ProposalLinkHelper
    • should be EntityLinkHelper
    • table names should be jade_<entity_type>_judgment not jade_<entity_type>_proposal
  • ProposalEntityType
    • should be EntityType?
  • ProposalPageWikitextRenderer
    • should be EntityPageWikitextRenderer
  • ProposalSummarizer
    • should be EntitySummarizer
  • ProposalTarget
    • should be EntityTarget
  • ProposalValidator
    • should be EntityValidator

Details

SubjectRepoBranchLines +/-
Rename ProposalEntityType -> EntityTypemediawiki/extensions/Jademaster+44 -44
Rename ProposalTarget -> EntityTargetmediawiki/extensions/Jademaster+44 -44
Rename ProposalValidator -> EntityValidatormediawiki/extensions/Jademaster+36 -36
Rename ProposalSummarizer -> EntitySummarizermediawiki/extensions/Jademaster+11 -11
Rename ProposalPageWikitextRenderer -> EntityPageWikitextRenderermediawiki/extensions/Jademaster+13 -13
Rename ProposalLinkTableHelper -> EntityLinkTableHelpermediawiki/extensions/Jademaster+22 -22
Rename ProposalLinkTable -> EntityLinkTablemediawiki/extensions/Jademaster+8 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Halfak created this task.Oct 8 2019, 9:20 PM
Halfak edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.
Halfak edited projects, added Machine-Learning-Team; removed Machine-Learning-Team (Active Tasks).Dec 4 2019, 5:30 PM
Halfak triaged this task as Low priority.Dec 4 2019, 9:38 PM
Halfak removed a project: Epic.
Halfak moved this task from Unsorted to Maintenance/cleanup on the Machine-Learning-Team board.
Halfak edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.Mar 16 2020, 4:56 PM
• ACraze updated the task description. (Show Details)Mar 18 2020, 12:21 AM
gerritbot added a comment.Mar 30 2020, 6:10 PM

Change 584670 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Rename ProposalLinkTable -> EntityLinkTable

https://gerrit.wikimedia.org/r/584670

gerritbot added a project: Patch-For-Review.Mar 30 2020, 6:10 PM
gerritbot added a comment.Mar 30 2020, 7:17 PM

Change 584678 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Rename ProposalLinkTableHelper -> EntityLinkTableHelper

https://gerrit.wikimedia.org/r/584678

gerritbot added a comment.Mar 31 2020, 6:14 AM

Change 584670 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Rename ProposalLinkTable -> EntityLinkTable

https://gerrit.wikimedia.org/r/584670

gerritbot added a comment.Mar 31 2020, 6:16 AM

Change 584678 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Rename ProposalLinkTableHelper -> EntityLinkTableHelper

https://gerrit.wikimedia.org/r/584678

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 31 2020, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 31 2020, 7:10 AM
gerritbot added a comment.Mar 31 2020, 9:12 PM

Change 585037 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Rename ProposalPageWikitextRenderer -> EntityPageWikitextRenderer

https://gerrit.wikimedia.org/r/585037

gerritbot added a project: Patch-For-Review.Mar 31 2020, 9:12 PM
gerritbot added a comment.Mar 31 2020, 10:38 PM

Change 585048 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Rename ProposalSummarizer -> EntitySummarizer

https://gerrit.wikimedia.org/r/585048

gerritbot added a comment.Apr 1 2020, 6:12 AM

Change 585037 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Rename ProposalPageWikitextRenderer -> EntityPageWikitextRenderer

https://gerrit.wikimedia.org/r/585037

gerritbot added a comment.Apr 1 2020, 6:42 AM

Change 585048 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Rename ProposalSummarizer -> EntitySummarizer

https://gerrit.wikimedia.org/r/585048

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2020, 7:11 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.27; 2020-04-07); removed MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Apr 1 2020, 12:00 PM
• ACraze updated the task description. (Show Details)Apr 1 2020, 5:49 PM
gerritbot added a comment.Apr 1 2020, 8:32 PM

Change 585315 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Rename ProposalValidator -> EntityValidator

https://gerrit.wikimedia.org/r/585315

gerritbot added a project: Patch-For-Review.Apr 1 2020, 8:32 PM
gerritbot added a comment.Apr 1 2020, 11:15 PM

Change 585346 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Rename ProposalTarget -> EntityTarget

https://gerrit.wikimedia.org/r/585346

gerritbot added a comment.Apr 2 2020, 7:05 AM

Change 585315 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Rename ProposalValidator -> EntityValidator

https://gerrit.wikimedia.org/r/585315

gerritbot added a comment.Apr 2 2020, 7:11 AM

Change 585346 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Rename ProposalTarget -> EntityTarget

https://gerrit.wikimedia.org/r/585346

Maintenance_bot removed a project: Patch-For-Review.Apr 2 2020, 8:10 AM
• ACraze updated the task description. (Show Details)Apr 2 2020, 4:39 PM
gerritbot added a comment.Apr 2 2020, 6:52 PM

Change 585575 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Rename ProposalEntityType -> EntityType

https://gerrit.wikimedia.org/r/585575

gerritbot added a project: Patch-For-Review.Apr 2 2020, 6:52 PM
• ACraze moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Apr 2 2020, 9:39 PM
gerritbot added a comment.Apr 3 2020, 6:34 AM

Change 585575 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Rename ProposalEntityType -> EntityType

https://gerrit.wikimedia.org/r/585575

Maintenance_bot removed a project: Patch-For-Review.Apr 3 2020, 7:11 AM
Halfak moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Apr 6 2020, 4:45 PM
• ACraze updated the task description. (Show Details)Apr 6 2020, 5:41 PM
Halfak closed this task as Resolved.Jun 22 2020, 4:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits