Newcomer tasks: Help panel height is shorter than expected
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Apr 15 2020, 7:00 PM

Description

The Desktop help panel is appearing shorter than the expected 528px height.

Proposed fix

1. Set a fixed height on the panel
Set on a class that includes height of the entire panel including header + footer (e.g., .oo-ui-window-frame) to be height:528px;

2. Set a max-height on the panel
In cases where the browser window is shorter than the height of the panel, the height of the panel should be shortened so that users can still access the help panel header actions, and be able to see the "Edit" tabs on the page.
Set the following max-height on the same class as item #1:
max-height: calc(100vh - 180px);

Details

	Subject	Repo	Branch	Lines +/-
	Fix help panel height	mediawiki/extensions/GrowthExperiments	master	+18 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Tgr	T250310 Newcomer tasks: Help panel height is shorter than expected
		Resolved	BUG REPORT	kostajh	T255607 [regression-wmf.37] Post-edit dialog display issue

Event Timeline

Etonkovidova created this task.Apr 15 2020, 7:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2020, 7:00 PM

Etonkovidova updated the task description. (Show Details)Apr 15 2020, 7:01 PM

Etonkovidova updated the task description. (Show Details)Apr 15 2020, 7:05 PM

Aklapper renamed this task from Naroow Help panel displayed in FF to Narrow Help panel displayed in FF.Apr 15 2020, 7:49 PM

Etonkovidova updated the task description. (Show Details)Apr 15 2020, 9:07 PM

Etonkovidova updated the task description. (Show Details)Apr 15 2020, 9:10 PM

MMiller_WMF renamed this task from Narrow Help panel displayed in FF to Newcomer tasks: narrow Help panel displayed in FF.Apr 15 2020, 11:09 PM

Based on offline conversation, retitled this to reflect that the bug is the panel height is not tall enough in FF (not width being too narrow).

Etonkovidova mentioned this in T247999: Newcomer tasks: animate transitions between panels.May 22 2020, 12:56 AM

@RHo will take action on this task following a team discussion.

RHo renamed this task from Newcomer tasks: Short Help panel displayed in FF to Newcomer tasks: Help panel height is shorter than expected.Jun 4 2020, 1:39 PM

RHo updated the task description. (Show Details)

RHo edited projects, added NewcomerTasks 1.2, Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

RHo moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Tgr claimed this task.Jun 11 2020, 3:48 PM

Tgr moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 604794 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix help panel height

https://gerrit.wikimedia.org/r/604794

gerritbot added a project: Patch-For-Review.Jun 11 2020, 4:42 PM

Tgr moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 11 2020, 4:42 PM

Change 604794 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix help panel height

https://gerrit.wikimedia.org/r/604794

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 15 2020, 12:00 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 15 2020, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 15 2020, 12:10 PM

For Design review - all specs seem to be in place.

Set a fixed height on the panel

Set on a class that includes height of the entire panel including header + footer (e.g., .oo-ui-window-frame) to be height:528px;

production	betalabs with the fix

Set a max-height on the panel

Screen Shot 2020-06-15 at 5.41.25 PM.png (622×744 px, 183 KB)

Thanks @Etonkovidova - I can't replicate the double-scrollbar that is occurring in your second screenshot from my Chrome browser so wonder if it browser dependent? In any case, think this is minor enough (certain subset of browsers, only if the browser window height is <724px ) when this would occur that IMHO we can call it a pass.

Tgr added a subtask: T255607: [regression-wmf.37] Post-edit dialog display issue.Jun 17 2020, 1:41 PM

Thank you!

MMiller_WMF closed subtask T255607: [regression-wmf.37] Post-edit dialog display issue as Resolved.Sep 2 2020, 11:58 PM

	F31867350: Screen Shot 2020-06-15 at 5.41.25 PM.png
	Jun 16 2020, 12:45 AM

	F31867347: Screen Shot 2020-06-15 at 5.45.27 PM.png
	Jun 16 2020, 12:45 AM

	F31867343: Screen Shot 2020-06-15 at 5.33.09 PM.png
	Jun 16 2020, 12:45 AM

Newcomer tasks: Help panel height is shorter than expectedClosed, ResolvedPublicActions