Watchlist Expiry: unable to set time from toast in monobook
Note, works in vector.
In monobook, when the expiry popup appears, it does not extend beyond the content area, hiding the dropdown if the page is very short (example)
Description
Description
Details
Details
Customize query in gerrit
Related Objects
Related Objects
- Mentioned In
- rSMNB9086f450af1d: Set top offset for notifications
T260413: Watchlist Expiry: Popup expiry dropdown cut off in Visual Editor - Mentioned Here
- T260432: Watchlist Expiry: Watchstar popup not always usable on VisualEditor
T260413: Watchlist Expiry: Popup expiry dropdown cut off in Visual Editor
Event Timeline
This comment was removed by MusikAnimal.
Comment Actions
Change 619841 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/skins/MonoBook@master] Prevent mw-notification from being cut-off
Comment Actions
I'm wondering if this can be fixed by the same fix as for T260413: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/620145
Comment Actions
Change 620145 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Move notification overlay outside mw-body
Comment Actions
Another (very minor) issue that the above patch seems to fix is that with $wgResourceLoaderDebug = true the notification area (on first load) flashes in at the top of the content area, before being moved out to the side. I can't reproduce this in production though, and in test it's only happening when triggering a notification manually from the JS console.
Comment Actions
Change 620145 merged by jenkins-bot:
[mediawiki/core@master] Move notification overlay outside $content
Comment Actions
Change 619841 abandoned by MusikAnimal:
[mediawiki/skins/MonoBook@master] Prevent mw-notification from being cut-off
Reason:
superseded by https://gerrit.wikimedia.org/r/c/mediawiki/core/ /620145/
Comment Actions
Change 626783 had a related patch set uploaded (by HMonroy; owner: HMonroy):
[mediawiki/core@master] Move notification overlay outside $content
Comment Actions
Change 626918 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Move notification area to end of body
Comment Actions
Change 626927 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/skins/MonoBook@master] Set top offset for notifications
Comment Actions
@Samwilson I notice after applying patch 626927 locally the height/bottom padding of the tabs ("page", "discussion", "edit") is larger. This is on MonoBook.
Also, after applying 626918 the font size in the notification popup seems smaller on MonoBook (Modern skin has similar problems).
Local:
Testwiki:
Comment Actions
Change 626783 abandoned by HMonroy:
[mediawiki/core@master] Move notification overlay outside $content
Reason:
A new solution has been developed in patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/ /626918
Comment Actions
Thanks for finding that error @Dom_Walton. I'm not able to replicate it – what are your browser font settings? Anyway maybe it's fixed in the latest patchset (returning to ems instead of rems for the size of that top area). Could you see what it looks like? Also the font size issue should be fixed.
Comment Actions
Ah, interesting. So I was able to reproduce on Firefox and Chromium, both with font size 16 (which I believe is the default). But, if I change the font size larger or smaller (even by a small amount) the issue does not appear.
Anyway maybe it's fixed in the latest patchset (returning to ems instead of rems for the size of that top area). Could you see what it looks like?
Thanks, now local looks the same as testwiki on Firefox and Chromium, even when changing browser font sizes.
Also the font size issue should be fixed.
Again, local and testwiki look the same to me on Firefox and Chromium.
Comment Actions
Change 626918 merged by jenkins-bot:
[mediawiki/core@master] Move notification area to end of body
Comment Actions
Change 626927 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Set top offset for notifications
Comment Actions
I cannot reproduce this anymore on MonoBook, nor any of the other skins (Vector new and legacy, Minerva, Modern and Timeless) and mobile.
As in T260413, I tested with different levels of zoom on Firefox and Safari.
For more details of the other testing done for this change, see T260432.
Test Environment: Various different versions of https://en.wikipedia.beta.wmflabs.org.
Comment Actions
I have tested this on beta, and the bug is no longer reproducible. Screenshot example provided below for a page that has minimal text (i.e., a case where we previously saw the issue occur). The pop-up is now behaving as expected. I'm marking this work as Done.
