Page MenuHomePhabricator
Create Task
Maniphest T262448

Unmatched closing tags are removed
Closed, ResolvedPublic
Actions

Description

Unmatched closing tags are always removed.

Near the comment:

Elsewhere on the page:

Details

SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.13.0-a18mediawiki/vendorwmf/1.36.0-wmf.20+1 K -700
Bump wikimedia/parsoid to 0.13.0-a18mediawiki/vendormaster+1 K -700
html2wt: Don't test for separator validity between unmodified nodesmediawiki/services/parsoidmaster+30 -2
vendor: Bump wikimedia/parsoid to 0.13.0-a15mediawiki/corewmf/1.36.0-wmf.16+1 -1
Bump wikimedia/parsoid to 0.13.0-a15mediawiki/vendorwmf/1.36.0-wmf.16+40 -27
Bump wikimedia/parsoid to 0.13.0-a15mediawiki/vendormaster+40 -27
Prevent selser corruption from unclosed tags in list items in some casesmediawiki/services/parsoidmaster+27 -14
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 Öffnen SieNoneT262408 [TRACKING] Selser issues on talk pages
 Resolved• ssastryT262448 Unmatched closing tags are removed

Event Timeline

matmarex created this task.Sep 9 2020, 5:32 PM
Restricted Application added a subscriber: revi. · View Herald TranscriptSep 9 2020, 5:32 PM
matmarex mentioned this in T261321: Inspect Reply Tool diffs for instances of corruption.Sep 9 2020, 5:33 PM
matmarex updated the task description. (Show Details)Sep 9 2020, 5:45 PM
Restricted Application added a subscriber: Stang. · View Herald TranscriptSep 9 2020, 5:45 PM
• ssastry triaged this task as Medium priority.Sep 17 2020, 6:13 PM
matmarex added a comment.Sep 28 2020, 5:41 PM

Many of the diffs we're seeing look really bad because they remove closing tags that actually seem to be matched to an opening tag at a glance, and are only unmatched because of incorrect nesting resulting in the relevant node being implicitly closed earlier. For example (from last week only):

• ssastry moved this task from Needs Triage to Current & Upcoming Work on the Parsoid board.Oct 1 2020, 4:37 PM
matmarex added a comment.Oct 2 2020, 5:34 PM

This can also happen when the unmatched closing tag is generated by a template:

ppelberg updated the task description. (Show Details)Oct 5 2020, 10:54 PM

Adding the following to the task description:

• ssastry added a comment.Oct 31 2020, 3:52 AM

https://github.com/wikimedia/parsoid/blob/64bb480b59983f6f698aa41fa900d1a28d5e82b8/tests/parser/selserWrappingParserTests.txt#L123-L140 indicates that we won't be able to prevent some instances of these dirty diffs right now.

gerritbot added a comment.Nov 3 2020, 12:36 AM

Change 638210 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Prevent selser corruption from unclosed tags in list items in some cases

https://gerrit.wikimedia.org/r/638210

gerritbot added a project: Patch-For-Review.Nov 3 2020, 12:36 AM
gerritbot added a comment.Nov 3 2020, 5:24 AM

Change 638210 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Prevent selser corruption from unclosed tags in list items in some cases

https://gerrit.wikimedia.org/r/638210

Maintenance_bot removed a project: Patch-For-Review.Nov 3 2020, 6:10 AM
gerritbot added a comment.Nov 3 2020, 10:50 PM

Change 638735 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a15

https://gerrit.wikimedia.org/r/638735

gerritbot added a project: Patch-For-Review.Nov 3 2020, 10:50 PM
gerritbot added a comment.Nov 3 2020, 11:30 PM

Change 638735 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a15

https://gerrit.wikimedia.org/r/638735

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.18; 2020-11-17).Nov 4 2020, 12:00 AM
gerritbot added a comment.Nov 4 2020, 12:04 AM

Change 638520 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@wmf/1.36.0-wmf.16] Bump wikimedia/parsoid to 0.13.0-a15

https://gerrit.wikimedia.org/r/638520

• ssastry added a comment.Nov 4 2020, 4:08 PM

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User%3ASsastry%2Fsandbox&type=revision&diff=458747&oldid=458746 .. so, this bug is now fixed but, some minor whitespace dirty diffing in some cases cannot be avoided at this time.

gerritbot added a comment.Nov 4 2020, 4:27 PM

Change 638520 merged by jenkins-bot:
[mediawiki/vendor@wmf/1.36.0-wmf.16] Bump wikimedia/parsoid to 0.13.0-a15

https://gerrit.wikimedia.org/r/638520

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.16; 2020-11-03); removed MW-1.36-notes (1.36.0-wmf.18; 2020-11-17).Nov 4 2020, 5:00 PM
gerritbot added a comment.Nov 4 2020, 5:31 PM

Change 639214 had a related patch set uploaded (by Brennen Bearnes; owner: Brennen Bearnes):
[mediawiki/core@wmf/1.36.0-wmf.16] vendor: Bump wikimedia/parsoid to 0.13.0-a15

https://gerrit.wikimedia.org/r/639214

gerritbot added a comment.Nov 4 2020, 6:06 PM

Change 639214 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.16] vendor: Bump wikimedia/parsoid to 0.13.0-a15

https://gerrit.wikimedia.org/r/639214

gerritbot added a comment.Nov 26 2020, 1:50 AM

Change 643601 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] html2wt: Don't test for separator validity between unmodified nodes

https://gerrit.wikimedia.org/r/643601

gerritbot added a comment.Nov 30 2020, 8:17 PM

Change 643601 merged by jenkins-bot:
[mediawiki/services/parsoid@master] html2wt: Don't test for separator validity between unmodified nodes

https://gerrit.wikimedia.org/r/643601

gerritbot added a comment.Dec 1 2020, 3:40 AM

Change 644393 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644393

gerritbot added a comment.Dec 1 2020, 4:14 AM

Change 644221 had a related patch set uploaded (by C. Scott Ananian; owner: Subramanya Sastry):
[mediawiki/vendor@wmf/1.36.0-wmf.20] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644221

gerritbot added a comment.Dec 1 2020, 4:31 AM

Change 644393 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644393

gerritbot added a comment.Dec 1 2020, 2:04 PM

Change 644221 merged by jenkins-bot:
[mediawiki/vendor@wmf/1.36.0-wmf.20] Bump wikimedia/parsoid to 0.13.0-a18

https://gerrit.wikimedia.org/r/644221

• ssastry closed this task as Resolved.Dec 9 2020, 2:38 PM
• ssastry claimed this task.

I am going to resolve this since we've fixed all that we can fix here at this point. Any additional fixes needed here would need to look at ways to fix the stripped-tag lint errors (including maybe running maintenance scripts or bots).

Stang unsubscribed.Nov 13 2021, 11:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits