⚓ T263327 Deprecate SpecialBlock::canBlockEmail and replace its usages

Subject	Repo	Branch	Lines +/-
Do not call SpecialBlock::canBlockEmail in ApiBlock	mediawiki/core	master	+34 -2
[docs] BlockPermissionChecker::$targetType can be null	mediawiki/core	master	+1 -1
Move SpecialBlock::canBlockEmail to BlockPermissionChecker	mediawiki/core	master	+86 -9

Status	Subtype	Assigned	Task
Resolved		• Urbanecm	T250737 Special:Block should not play the role of a central blocking service/utility
Resolved	Oct 20 2020	Tchanders	T264303 Use BlockUser service in SpecialInvestigateBlock
Resolved		Daimona	T248743 Call BlockUser in AbuseFilterRunner.php
Duplicate		• Urbanecm	T264306 Use BlockUser service in GlobalBlocking
Resolved	Sep 22 2020	• Urbanecm	T189073 Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere
Resolved		• Urbanecm	T263327 Deprecate SpecialBlock::canBlockEmail and replace its usages
Resolved		• Urbanecm	T263334 Do not call SpecialBlock::canBlockEmail from CheckUser

• Urbanecm created this task.Sep 19 2020, 4:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2020, 4:27 PM

Change 628432 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Move SpecialBlock::canBlockEmail to BlockPermissionChecker

https://gerrit.wikimedia.org/r/628432

gerritbot added a project: Patch-For-Review.Sep 19 2020, 4:28 PM

• Urbanecm claimed this task.Sep 19 2020, 4:31 PM

• Urbanecm triaged this task as Low priority.

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptSep 19 2020, 4:31 PM

Change 628378 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] [docs] BlockPermissionChecker::$targetType can be null

https://gerrit.wikimedia.org/r/628378

Change 628432 merged by jenkins-bot:
[mediawiki/core@master] Move SpecialBlock::canBlockEmail to BlockPermissionChecker

https://gerrit.wikimedia.org/r/628432

Change 628378 merged by jenkins-bot:
[mediawiki/core@master] [docs] BlockPermissionChecker::$targetType can be null

https://gerrit.wikimedia.org/r/628378

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 19 2020, 6:00 PM

Change 628505 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Do not call SpecialBlock::canBlockEmail in ApiBlock

https://gerrit.wikimedia.org/r/628505

Maintenance_bot moved this task from Backlog to Waiting on review on the User-Urbanecm board.Sep 19 2020, 6:24 PM

Change 628505 merged by jenkins-bot:
[mediawiki/core@master] Do not call SpecialBlock::canBlockEmail in ApiBlock

https://gerrit.wikimedia.org/r/628505

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2020, 7:10 PM