| Tgr | |
| Sep 26 2020, 5:13 AM |
| F32364162: T263905-enwiki-beta.png | |
| Sep 26 2020, 5:17 AM |
| F32364160: T263905-testwiki.png | |
| Sep 26 2020, 5:17 AM |
(Probably other skins too at the right width, but with new Vector it is particularly visible.)
testwiki:
beta enwiki:
Sort of a regression of T263068: Mentor module and help module display broken on narrow desktop screens although it doesn't look 100% the same.
It follows from 2bebec468b452fd3d3fc6f8d74981ee9e86dbc47 which set a minimum width of 1200px. This is only a problem for variant A. We could bandaid fix this with a minimum width for the sidebar for variant A (that would have some issues too) to tide us over until Variants C/D go live. @RHo thoughts?
Hi @kostajh, Yes that's a good idea. Can we set a min-width of the sidebar to 300px?
The Vector refresh has max-width:1650px on the whole page (for my screen size anyway), min-width:1200px for the main block + min-width:300px for the sidebar + ~300px for the Vector sidebar overruns that, so you end up with a vertically scrolling page.
Change 630706 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Ensure variant A homepage sidebar is always at least 300px
FYI, @Dyolf77_WMF independently noticed this today.
FYI @olga -- in case you want to keep track of any reverberations from your team's updates. It looks like we are fixing this one.
Change 630706 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Ensure variant A homepage sidebar is always at least 300px
Change 630801 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.11] Ensure variant A homepage sidebar is always at least 300px
Change 630801 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.11] Ensure variant A homepage sidebar is always at least 300px
Mentioned in SAL (#wikimedia-operations) [2020-09-30T00:41:20Z] <tgr@deploy1001> Synchronized php-1.36.0-wmf.11/extensions/GrowthExperiments/: Backport: [[gerrit:630801|Ensure variant A homepage sidebar is always at least 300px (T263905)]] (duration: 01m 01s)