Page MenuHomePhabricator
Create Task
Maniphest T273782

Help desk errors out when GEHelpPanelAskMentor is true and there are no mentors available
Closed, ResolvedPublic
Actions

Description

While looking into T273776, I noticed that help panel errors out when GEHelpPanelAskMentor is set to true and there are no mentors available. That should be fixed, so help desk simply does not allow any questions to be asked in such a scenario.

Details

SubjectRepoBranchLines +/-
Make help panel fallback to help desk if no mentor is availablemediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.33+12 -6
Make help panel fallback to help desk if no mentor is availablemediawiki/extensions/GrowthExperimentsmaster+12 -6
Make help panel fallback to help desk if no mentor is availablemediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.34+12 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Urbanecm_WMF created this task.Feb 3 2021, 4:46 PM
• Urbanecm_WMF mentioned this in T273773: Scale: ability to deploy without help desk feature.Feb 3 2021, 5:08 PM
• Urbanecm_WMF mentioned this in T273776: Scale: ability to deploy without mentorship module.Feb 17 2021, 4:49 PM
gerritbot added a comment.Mar 9 2021, 3:02 AM

Change 670021 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670021

gerritbot added a project: Patch-For-Review.Mar 9 2021, 3:02 AM
• Urbanecm_WMF claimed this task.Mar 9 2021, 3:02 AM
• Urbanecm_WMF triaged this task as High priority.
• Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)), User-Urbanecm_WMF (Engineering); removed Growth-Team.
• Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

High => breaks help panel on several wikis.

kostajh subscribed.Mar 9 2021, 7:54 AM

@Urbanecm_WMF is this the same issue as T276759: TypeError: title is undefined? Could you say more about which wikis, and how it breaks exactly (error message)? Thanks!

• Urbanecm_WMF added a comment.Mar 9 2021, 8:37 AM
In T273782#6895025, @kostajh wrote:

@Urbanecm_WMF is this the same issue as T276759: TypeError: title is undefined? Could you say more about which wikis, and how it breaks exactly (error message)? Thanks!

The error from console:

Uncaught TypeError: Cannot read property 'replace' of undefined

Traceback is at P14678.

I'd say it's a different error, considering you filled T276759 before the deployment of T275908.

gerritbot added a comment.Mar 9 2021, 9:30 AM

Change 670021 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670021

gerritbot added a comment.Mar 9 2021, 9:32 AM

Change 670108 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.34] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670108

gerritbot added a comment.Mar 9 2021, 9:38 AM

Change 670109 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.33] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670109

gerritbot added a comment.Mar 9 2021, 9:45 AM

Change 670108 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.34] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670108

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 9 2021, 10:00 AM
gerritbot added a comment.Mar 9 2021, 12:12 PM

Change 670109 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.33] Make help panel fallback to help desk if no mentor is available

https://gerrit.wikimedia.org/r/670109

Stashbot mentioned this in T275908: Scale: default to mentorship questions from help panel.Mar 9 2021, 12:16 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-09T12:16:16Z] <urbanecm@deploy1002> Synchronized php-1.36.0-wmf.33/extensions/GrowthExperiments/: dbd6f0cb299bcfb6648b351e1476100fe669cc58: Make help panel fallback to help desk if no mentor is available (T275908; T273782) (duration: 01m 01s)

• Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 9 2021, 12:16 PM
• Urbanecm_WMF moved this task from Backlog to My Part Done on the User-Urbanecm_WMF (Engineering) board.
• Urbanecm_WMF added a subscriber: Etonkovidova.

@Etonkovidova Hello, this is the bug that made dawiki help panel gone temporarily. Moving to QA, as it should be fixed (at least it works for me now :)).

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.33; 2021-03-02); removed MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 9 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 9 2021, 1:10 PM
kostajh mentioned this in T276966: GrowthExperiments help error : TypeError: title is undefined, Uncaught TypeError: Cannot read property 'replace' of undefined.Mar 9 2021, 7:57 PM
Etonkovidova closed this task as Resolved.Mar 11 2021, 1:28 AM
In T273782#6896048, @Urbanecm_WMF wrote:

@Etonkovidova Hello, this is the bug that made dawiki help panel gone temporarily. Moving to QA, as it should be fixed (at least it works for me now :)).

Checked. Also tested betalabs for the case when Wikipedia:Mentors page is blank - all seem to be fine.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits