Analysis is blocked on T271763.

Change 704883 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/extensions/Popups@master] POC: Adjust top padding of popup to account for clip path

https://gerrit.wikimedia.org/r/704883

POC above. There are several issues going on here (one of which is the text's margin getting clipped as a result of clip-path which @thiemowmde pointed out).

Change 704883 abandoned by Nray:

[mediawiki/extensions/Popups@master] POC: Adjust top padding of popup to account for clip path

Reason:

POC only. Reopen if helpful

https://gerrit.wikimedia.org/r/704883

Change 705510 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Remove the page preview icon hacks

https://gerrit.wikimedia.org/r/705510

Change 704883 restored by Jdlrobson:

[mediawiki/extensions/Popups@master] POC: Adjust top padding of popup to account for clip path

https://gerrit.wikimedia.org/r/704883

Change 704883 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Adjust top padding of popup to account for clip path

https://gerrit.wikimedia.org/r/704883

Change 707671 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/Popups@master] Fix regression with reference previews

https://gerrit.wikimedia.org/r/707671

This also caused T287520

Change 707671 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix regression with reference previews

https://gerrit.wikimedia.org/r/707671

Test Result - Beta

Status: ✅ PASS
Environment: beta/Storybook
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Navigate to a page on beta cluster i.e. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein
✅ AC1: Hover over reference links to see that the icon in the left hand corner is consistent with spacing between the different types of reference links

✅ To check the disambiguation popup, see https://doc.wikimedia.org/Popups/master/js/ui/?path=/story/disambiguation--standard (I couldn't find an example of a working disambiguation popup on beta cluster)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Navigate to a page on beta cluster i.e. https://en.wikipedia.org/wiki/Albert_Einstein
❓ AC1: Hover over reference links to see that the icon in the left hand corner is consistent with spacing between the different types of reference links
I can't find a reference link with an icon on the tip left of the popupl

✅ AC2: Check the disambiguation popup
Visually it looks consistent. I took some screenshots where I could show the padding.

❓ AC1: Hover over reference links to see that the icon in the left-hand corner is consistent with spacing between the different types of reference links

Strange. Perhaps this feature is beta only for now. I think it's fine to sign this off given beta cluster pass.

@Edtadros @Jdlrobson The reference previews need to be enabled first from the beta features tab

It's enabled for me and that doesn't help for some reason. Are you seeing the icons and title "Journal" heading @nray ?

@Jdlrobson Yes, I see them. I forgot to mention per the instructions on the reference previews that you have to have the navigation popups and reference previews gadgets turned off as well:

Please note: If you're using the Navigation popups gadget or the Reference Tooltips gadget, you won't see reference previews.

Right, yep mine was turned on for me as it defaults to on :( I can test this now.
@Edtadros DM me if you have any follow-up questions.

I found an error in the error preview:

We don't have a storybook entry for that so we should add it.

Am also seeing padding inconsistency on one of the popup variants in the links Hadrian and Theodosius in the text "Roman emperors such as Trajan, Hadrian or Theodosius"

This can also be seen in storybook in "Page preview flipped-x (landscape) with thumbnail" variant on https://doc.wikimedia.org/Popups/master/js/ui/?path=/story/thumbnails--landscape

In T281170#7276222, @Jdlrobson wrote:

I found an error in the error preview:

We don't have a storybook entry for that so we should add it.

hi @Jdlrobson - can you provide a sample link to replicate the error preview?

@cjming for the page issue https://doc.wikimedia.org/Popups/master/js/ui/?path=/story/thumbnails--landscape
Also https://en.wikipedia.org/wiki/Spain article, Trajan link, but you'll likely need to turn off the floating of the infobox.

For the error preview the easiest way to do this is to break the config:

$wgPopupsGateway = 'restbaseHTML';
$wgPopupsRestGatewayEndpoint = 'https://blahblahblah.wikipedia.org/api/rest_v1/page/summary/';
``

Change 712997 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/Popups@master] Fix popup preview regressions, add story

https://gerrit.wikimedia.org/r/712997

Change 712997 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix popup preview regressions, add story

https://gerrit.wikimedia.org/r/712997

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Navigate to a page on beta cluster i.e. https://en.wikipedia.org/wiki/Albert_Einstein
✅ AC1: Hover over reference links to see that the icon in the left hand corner is consistent with spacing between the different types of reference links
I found a few icons, they look fine.

✅ AC2: Check the disambiguation popup
Visually it looks consistent. I took some screenshots where I could show the padding.