Page MenuHomePhabricator

Move Content::preloadTransform method that don't belong in Content to ContentHandler
Closed, ResolvedPublic

Description

These methods need to move to new corresponding methods in ContentHandler. Here's a patch that does the first part of the work for Content::preSaveTransform.

The signature of the ContentHandler method should be:

  • ContentHandler::preloadTransform( Content, PageReference, ParserOptions, array )

The process:

  • Do the same as in the referenced patch for all the methods.
  • In all extensions where Content overriding classes override the method - override the ContentHandler method instead
    • ProofreadPage
  • Replace all callers. Use ContentHandlerFactory to obtain a ContentHandler, not the Content::getContentHandler method
  • Once all callers and overrides in extensions is done, do some hard deprecations.

Event Timeline

Change 711126 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Move Content::preloadTransform to ContentHandler

https://gerrit.wikimedia.org/r/711126

Change 712936 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/ProofreadPage@master] Override ContentHandler::preloadTransform instead of Content::preloadTransform.

https://gerrit.wikimedia.org/r/712936

daniel renamed this task from Move Content::preLoadTransform method that don't belong in Content to ContentHandler to Move Content::preloadTransform method that don't belong in Content to ContentHandler.Aug 16 2021, 2:57 PM
daniel updated the task description. (Show Details)

Change 713474 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/VisualEditor@master] Replace Content::preloadTransform call to ContentTransformer::preloadTransform

https://gerrit.wikimedia.org/r/713474

Change 711126 merged by jenkins-bot:

[mediawiki/core@master] Move Content::preloadTransform to ContentHandler

https://gerrit.wikimedia.org/r/711126

Change 713893 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Remove Content::preloadTransform tests that now useless.

https://gerrit.wikimedia.org/r/713893

Change 713893 abandoned by Roman Stolar:

[mediawiki/core@master] Remove Content::preloadTransform tests that now useless.

Reason:

Will be removed in another patch.

https://gerrit.wikimedia.org/r/713893

Change 714335 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Hard-deprecate Content::preloadTransform.

https://gerrit.wikimedia.org/r/714335

Change 713474 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Replace Content::preloadTransform call to ContentTransformer::preloadTransform

https://gerrit.wikimedia.org/r/713474

Change 712936 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Override ContentHandler::preloadTransform instead of Content::preloadTransform.

https://gerrit.wikimedia.org/r/712936

Change 714335 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate Content::preloadTransform.

https://gerrit.wikimedia.org/r/714335