Page MenuHomePhabricator

Minifier can sometimes split "..." spread operator (affects Vue 3.1.5-compat)
Closed, ResolvedPublic

Description

Minifying vue.global.prod.js from @vue/compat version 3.1.5 (this file) causes a syntax error, because the minifier inserts a newline in the middle of a spread (...) operator:

const t=Nl().createApp(.
..e),{mount:n}=t;

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 708368 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/libs/Minify@master] JavaScriptMinifer: Recognize '...' as a single token

https://gerrit.wikimedia.org/r/708368

Change 708378 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] Update wikimedia/minify to 2.2.4

https://gerrit.wikimedia.org/r/708378

Change 708379 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@REL1_36] Update wikimedia/minify to 2.2.4 (backport)

https://gerrit.wikimedia.org/r/708379

Krinkle renamed this task from Vue 3.1.5-compat is incorrectly minified to Minifier can sometimes split "..." spread operator (affects Vue 3.1.5-compat).Jul 27 2021, 11:14 PM

Change 708380 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/libs/Minify@master] Tag 2.2.4

https://gerrit.wikimedia.org/r/708380

Change 708368 merged by jenkins-bot:

[mediawiki/libs/Minify@master] JavaScriptMinifer: Recognize `...` as a single token

https://gerrit.wikimedia.org/r/708368

Change 708380 merged by jenkins-bot:

[mediawiki/libs/Minify@master] Tag 2.2.4

https://gerrit.wikimedia.org/r/708380

Change 708378 merged by jenkins-bot:

[mediawiki/core@master] Update wikimedia/minify to 2.2.4

https://gerrit.wikimedia.org/r/708378

Change 708379 merged by jenkins-bot:

[mediawiki/core@REL1_36] Update wikimedia/minify to 2.2.4 (backport)

https://gerrit.wikimedia.org/r/708379