Page MenuHomePhabricator

Edit a story
Closed, ResolvedPublic

Description

Open an existing story in the story builder, modify it and save it.

  • "Edit" link somewhere in the viewer
  • Consider replacing the "Edit" tab on the Story namespace page with a js handler that opens up the builder

Event Timeline

Change 791607 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Rename SpecialCreateStory to SpecialStoryBuilder

https://gerrit.wikimedia.org/r/791607

SBisson triaged this task as Medium priority.
SBisson moved this task from Definition to Dev on the Inuka-Team (Kanban) board.
SBisson added a subscriber: SGautam_WMF.

@SGautam_WMF I'm starting this task. I can make progress but I'll need to know soon where to put the 'edit' button.

Change 791607 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Rename SpecialCreateStory to SpecialStoryBuilder

https://gerrit.wikimedia.org/r/791607

Change 792675 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Edit story in StoryBuilder

https://gerrit.wikimedia.org/r/792675

Change 792675 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Edit story in StoryBuilder

https://gerrit.wikimedia.org/r/792675

Testing:

Passed scenarios:

  1. Clicking on "Edit" on the story title page opens up the first page for editing,
  2. Clicking on "Edit" on a page opens up the page for editing.
  3. For users not logged in, clicking on "Edit" prompts them to log in and then returns them to the "Edit Wikistory" section.
  4. A page can be successfully edited and saved.
  5. The story title is not editable when published.
  6. History of the changes can be seen on the wiki page.
  7. Other functions like deleting a story page, replacing an image and choosing a maximum of 10 images still work.
  8. Works on all current versions of Chrome, Firefox and Safari.

Improvements:

  1. The icon on the "Edit" label does not appear to be aligned with the text

image.png (310×996 px, 293 KB)

  1. From viewer, when a wikistory is closed, there is an error on the console

image.png (734×878 px, 278 KB)

Improvements:

  1. The icon on the "Edit" label does not appear to be aligned with the text

I'll let this be fixed during one of the design improvement sessions that Sudhanshu is doing with Huei or Eduardo

  1. From viewer, when a wikistory is closed, there is an error on the console

I made a small patch to fix this and another similar error. It happened at the same time as the edit story work but it is not really related.

Looks great! No error is showing up in console any more.

{F35247628}

@SBisson Is it possible to open the story builder with story page on which a user has clicked on the edit button? As of now, it starts with the first story page.

@SBisson Is it possible to open the story builder with story page on which a user has clicked on the edit button? As of now, it starts with the first story page.

Yes, it's possible. Could you file a new task for it?

created following T311498 to address the additional improvement.