| Jdlrobson | |
| Feb 8 2022, 4:07 PM |
| F34982568: Screen Recording 2022-03-07 at 9.22.45 AM.mov.gif | |
| Mar 7 2022, 5:25 PM |
| F34974071: Screen Recording 2022-03-03 at 10.26.35 AM.mov.gif | |
| Mar 3 2022, 6:30 PM |
| F34972771: Screen Shot 2022-03-02 at 12.11.00 PM.png | |
| Mar 2 2022, 7:16 PM |
| F34971406: Screen Recording 2022-03-01 at 9.24.48 AM.mov.gif | |
| Mar 1 2022, 5:29 PM |
| F34971408: Screen Recording 2022-03-01 at 9.26.13 AM.mov.gif | |
| Mar 1 2022, 5:29 PM |
Likely caused by T294164
Expected: search performed
actual: nothing
The submit button for the search is outside the form. The HTML should be updated so that's not the case.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T301257#7757713 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Search icon should be part of search form for grade C browsers | mediawiki/skins/MinervaNeue | master | +33 -12 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | ovasileva | T301257 [Regression] Can't search on mobile on grade C browsers | ||
| Resolved | BUG REPORT | Edtadros | T302753 [Regression, wmf.24-mobile] Search icon is misplaced |
Change 764846 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Search icon should be part of search form for grade C browsers
Change 764846 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Search icon should be part of search form for grade C browsers
Status: ❌ Fail
Environment: beta
OS: macOS Monterey
Browser: Chrome 70
Device: MBP
Emulated Device:NA
Test Artifact(s):
Disable JS or use an older device
Visit any page
Type in search box
Click search icon
❌ AC1: Expected: search performed
Chrome 70 (Grade C per https://www.mediawiki.org/wiki/Compatibility#Basic_(Grade_C)) with JS turned off
Chrome 70 with JS turned on
hi @Edtadros -- I might be misunderstanding the bug and the fix but testing mediawiki mobile search with javascript disabled, I was under the impression we are testing clicking on the search icon over to the right, not the one inside the search input itself:
If you compare to prod enwiki (mobile, javascript disabled - on 1.38.0-wmf.23) https://en.m.wikipedia.org/wiki/Dog, enter a search term, and then click on the icon over to the right, it doesn't do anything but on mediawiki (mobile, javascript disabled - on 1.38.0-wmf.24), it does return results in the main content area.
Thanks @cjming, I'm retesting now looking at the correct search icon.
Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome with JS disabled
Device: MBP
Emulated Device:NA
Test Artifact(s):
Disable JS or use an older device
Visit any page
Type in search box
Click search icon
✅ AC1: Expected: search performed
Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome with JS disabled
Device: MBP
Emulated Device:NA
Test Artifact(s):
Disable JS or use an older device
Visit any page
Type in search box
Click search icon
✅ AC1: Expected: search performed
