Maniphest T302303

🟦 Enable linting for php code
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Silvan_WMDE
	Feb 22 2022, 3:21 PM

Tags

Referenced Files

None

Subscribers

Ollie.Shotton_WMDE

Description

use the standard Wikibase rules (see .phpcs.xml at wikibase root)
add a sniff to require setting strict_types=1 in the new rest-api directory
add a sniff to require type hints on all methods

Details

	Subject	Repo	Branch	Lines +/-
	REST: extend Wikibase PHPCS config in rest-api dir	mediawiki/extensions/Wikibase	master	+19 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		WMDE-leszek	T302268 🟦 Initial set up of the boiler plate Wikibase REST API
		Resolved		Jakob_WMDE	T302303 🟦 Enable linting for php code

Event Timeline

Silvan_WMDE created this task.Feb 22 2022, 3:21 PM

Silvan_WMDE mentioned this in T302268: 🟦 Initial set up of the boiler plate Wikibase REST API.

Silvan_WMDE renamed this task from Enable linting for php code to 🟦 Enable linting for php code.Feb 23 2022, 8:22 AM

Jakob_WMDE claimed this task.Feb 23 2022, 9:12 AM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 1) board.

Change 765251 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: extend Wikibase PHPCS config in rest-api dir

https://gerrit.wikimedia.org/r/765251

gerritbot added a project: Patch-For-Review.Feb 23 2022, 12:14 PM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 1) board.Feb 23 2022, 1:05 PM

Change 765251 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: extend Wikibase PHPCS config in rest-api dir

https://gerrit.wikimedia.org/r/765251

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2022, 9:10 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 25 2022, 10:00 AM

Silvan_WMDE moved this task from Peer Review to Test (Verification) on the Wikibase Product Platform (v1) (Sprint 1) board.Feb 25 2022, 10:02 AM

Jakob_WMDE moved this task from Test (Verification) to Done on the Wikibase Product Platform (v1) (Sprint 1) board.Feb 28 2022, 1:55 PM

WMDE-leszek closed this task as Resolved.Mar 11 2022, 3:49 PM