Page MenuHomePhabricator

UnreviewedPagesPager should work with ONLY_FULL_GROUP_BY in sql_mode
Closed, ResolvedPublic

Description

seen with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/773915:

Error 1055 from IndexPager::buildQueryInfo (UnreviewedPagesPager), 'wikidb.unittest_page.page_namespace' isn't in GROUP BY
SELECT  page_namespace,page_title,page_len,page_id,MIN(rev_timestamp) AS creation  FROM `unittest_page` FORCE INDEX (page_name_title) LEFT JOIN `unittest_flaggedpages` ON ((fp_page_id=page_id)) LEFT JOIN `unittest_revision` FORCE INDEX (rev_page_timestamp) ON ((rev_page=page_id))   WHERE (fp_page_id IS NULL) AND page_namespace = 0 AND page_is_redirect = 0  GROUP BY page_title ORDER BY page_title LIMIT 51

Event Timeline

Tacsipacsi changed the task status from Open to In Progress.Mar 26 2022, 3:16 PM
Tacsipacsi claimed this task.
Tacsipacsi subscribed.

I don’t have much experience with DB handling in MediaWiki, but I’ll give it a try.

Change 773935 had a related patch set uploaded (by Tacsipacsi; author: Tacsipacsi):

[mediawiki/extensions/FlaggedRevs@master] GROUP BY all non-aggregated fields in UnreviewedPagesPager

https://gerrit.wikimedia.org/r/773935

Change 773935 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] GROUP BY all non-aggregated fields in UnreviewedPagesPager

https://gerrit.wikimedia.org/r/773935