Maniphest T309843

🟩️ Create StatementValidator
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Silvan_WMDE
	Jun 3 2022, 10:03 AM

Tags

Referenced Files

None

Subscribers

Description

create StatementValidator interface in Wikibase\Repo\RestApi\Validation
- has two methods: validate( array $serializedStatement ): ?ValidationError and getValidatedStatement(): ?Statement
implement StatementValidator interface using SnakValidator and StatementDeserializer in new namespace similar to DataAccess (may have external dependencies)
- deserializes the statement first and writes it to an instance property (with a getter method)
- use SnakValidator for validation post deserialization

Details

	Subject	Repo	Branch	Lines +/-
	REST: Add StatementValidator	mediawiki/extensions/Wikibase	master	+176 -0
	REST: Use StatementValidator in AddItemStatementValidator	mediawiki/extensions/Wikibase	master	+18 -11

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ifrahkhanyaree_WMDE	T344228 Functionality for REST API v1
		Resolved		WMDE-leszek	T306667 🟩️ Create a statement on an item via POST /entities/items/{item_id}/statements
		Resolved		Jakob_WMDE	T309843 🟩️ Create StatementValidator

Event Timeline

Silvan_WMDE created this task.Jun 3 2022, 10:03 AM

Silvan_WMDE mentioned this in T309847: 🟩️ Add validation to AddItemStatement use case.Jun 3 2022, 10:11 AM

WMDE-leszek moved this task from Sprint 7 to Sprint 8 on the Wikibase Product Platform (v1) board.Jun 8 2022, 10:05 AM

WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 8); removed Wikibase Product Platform (v1) (Sprint 7).

Jakob_WMDE claimed this task.Jun 8 2022, 12:11 PM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 8) board.

Change 803931 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add StatementValidator

https://gerrit.wikimedia.org/r/803931

gerritbot added a project: Patch-For-Review.Jun 8 2022, 2:27 PM

Change 804278 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Use StatementValidator in AddItemStatementValidator

https://gerrit.wikimedia.org/r/804278

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 8) board.Jun 9 2022, 3:21 PM

Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 8) board.Jun 10 2022, 10:08 AM

Change 803931 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add StatementValidator

https://gerrit.wikimedia.org/r/803931

Change 804278 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use StatementValidator in AddItemStatementValidator

https://gerrit.wikimedia.org/r/804278

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2022, 10:29 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 10 2022, 11:00 AM

WMDE-leszek closed this task as Resolved.Jul 11 2022, 8:51 AM

Jakob_WMDE mentioned this in T313021: 🟫 Validate ReplaceItemStatement use case input.Jul 14 2022, 12:33 PM