Autosuggest does not work with macOS 13.0 Safari 16.0
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	GMikesell-WMF
	Jan 25 2023, 7:39 PM

Description

Steps to replicate the issue (include links if applicable):

Create a common.js with the following below in test.wikipedia AutosuggestSitelinkDebug = true; mw.loader.load('https://test.wikipedia.org/w/index.php?title=User:HMonroy_(WMF)/AutosuggestSitelink.js&action=raw&ctype=text/javascript');
Go to https://test.wikipedia.org/wiki/Killer_Croc

What happens?:

Autosuggest popup does not appear in just Safari 16.0

What should have happened instead?:
Autosuggest popup should appear in Safari 16.0 as seen in the screenshots like the other different browsers below

Other information (browser name/version, screenshots, etc.):

Autosuggest-Browser	macOS: Ventura 13.0	Windows 11
Safari 16: Fail		K.A.
Chrome 109: Good		Same as Mac
FireFox 108: Good	Same as Windows
Edge 109: Good	K.A.

QA Results - Meta-Wiki

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T327950 here

Related Objects

Mentioned In: T308059: Gadget: Autosuggest linking Wikidata item after creating an article

Event Timeline

GMikesell-WMF created this task.Jan 25 2023, 7:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2023, 7:39 PM

GMikesell-WMF mentioned this in T308059: Gadget: Autosuggest linking Wikidata item after creating an article.Jan 25 2023, 7:42 PM

MusikAnimal added a project: AutosuggestSitelink.Feb 1 2023, 8:51 PM

HMonroy added a project: WMF-Internships-2023.Feb 16 2023, 8:52 PM

• JMcLeod_WMF set the point value for this task to 3.Feb 22 2023, 3:35 PM

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-41); removed Community-Tech (CommTech-Sprint-40).Feb 27 2023, 4:45 PM

MusikAnimal added a project: Browser-Support-Apple-Safari.Mar 6 2023, 7:08 PM

@GMikesell-WMF Any chance we can get you to share the errors (assuming there are some) from the JS console? I don't have a Mac and can't test Safari, but I assume we're just using some JS feature that isn't available on Safari. The console hopefully will tell us what the issue is. Instructions on reporting JS errors can be found at w:WP:JSERROR if that helps.

• S_Mukuti moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-41) board.Mar 13 2023, 12:45 PM

• S_Mukuti claimed this task.Mar 13 2023, 12:49 PM

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-42); removed Community-Tech (CommTech-Sprint-41).Mar 13 2023, 1:43 PM

• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-42) board.Mar 13 2023, 1:48 PM

The dialog showed for me in 16.3 (after making an edit).

TheresNoTime subscribed.Mar 16 2023, 11:19 AM

fwiw, the error is unhandled promise rejection http

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech (CommTech-Sprint-42), Browser-Support-Apple-Safari, WMF-Internships-2023, AutosuggestSitelink, Wikimedia Wishathon.Mar 27 2023, 3:46 PM

• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.Mar 27 2023, 3:58 PM

• JMcLeod_WMF added projects: Browser-Support-Apple-Safari, WMF-Internships-2023, AutosuggestSitelink, Wikimedia Wishathon.Mar 27 2023, 4:24 PM

Notes from collab

We could try changing the Promise in init() to a normal $.when( mw.loader.using( [ 'mediawiki.util' ] ), $.ready ).then( function () {

https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/29

TheresNoTime moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Apr 5 2023, 10:49 AM

TheresNoTime moved this task from Review/Feedback 💬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.Apr 6 2023, 11:45 AM

KSiebert removed a project: Wikimedia Wishathon.May 4 2023, 7:41 PM

Restricted Application edited projects, added Community-Tech; removed Community-Tech (CommTech-Kanban). · View Herald TranscriptMay 4 2023, 7:41 PM

• S_Mukuti removed • S_Mukuti as the assignee of this task.Jun 27 2023, 1:15 PM

• S_Mukuti subscribed.

TheresNoTime moved this task from New & TBD Tickets to Maintenance Backlog on the Community-Tech board.Jul 12 2023, 2:09 PM

JWheeler-WMF moved this task from Maintenance Backlog to Up Next (June 3-21) on the Community-Tech board.Mar 29 2024, 5:53 PM

JWheeler-WMF edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.Apr 8 2024, 3:16 PM

JWheeler-WMF moved this task from In Development 💻 to Ready 🎬 on the Community-Tech (CommTech-Kanban) board.

Is this still an issue, after the recent work? (I don't have Safari so can't test.)

Samwilson moved this task from Backlog to Ready to work on on the AutosuggestSitelink board.Apr 16 2024, 12:53 AM

TheresNoTime claimed this task.Apr 17 2024, 10:12 AM

Unable to replicate (Version 17.4.1 (19618.1.15.11.14)), however will note that after saving a page the AutoSuggestSitelink modal does not pop up. It works as expected when clicking on the link in the toolbox.

@Samwilson I am not coming across that issue anymore or from any other browsers or skins after the recent work. This will be moved to Done. Thanks for all your work!

Status: ✅PASS
Environment: Meta-Wiki
OS: macOS Sonoma 14.4.1, Ventura
Browser: Safari 16.5.1 & 17.4.1, Chrome 123, Firefox 124
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: BrowserStack for Ventura
Test Links:
https://meta.wikimedia.org/wiki/Bot

✅AC1: https://phabricator.wikimedia.org/T327950

Ventura-Safari 16.5.1	Sonoma-Safari 17.4.1

GMikesell-WMF updated the task description. (Show Details)Apr 17 2024, 7:52 PM

GMikesell-WMF moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

TheresNoTime closed this task as Resolved.May 22 2024, 10:24 AM

	F36487086: T308059_Autosuggest_Windows_Edge.png
	Jan 25 2023, 7:39 PM

	F36487084: T308059_Autosuggest_Windows_FF.png
	Jan 25 2023, 7:39 PM

	F36487081: T308059_Autosuggest_MacVentura_Chrome.png
	Jan 25 2023, 7:39 PM

	F36487079: T308059_Autosuggest_MacVentura_Safari_Fail.png
	Jan 25 2023, 7:39 PM

Autosuggest does not work with macOS 13.0 Safari 16.0Closed, ResolvedPublic3 Estimated Story PointsBUG REPORTActions

Description

QA Results - Meta-Wiki

Related Objects

Event Timeline

Autosuggest does not work with macOS 13.0 Safari 16.0
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions