Anonymous editor warning login link doesn't include returnto parameter
Closed, ResolvedPublic8 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Use private browsing mode
Go to a Wikidata item (e.g. https://www.wikidata.org/wiki/Q7988722)
Edit a statement
Click on the log in/create account link in the anonymous edit warning

What happens?:
The corresponding link does not include the returnto parameter, which means that the editor will not automatically return to the item after logging in/creating an account.

What should have happened instead?:
The corresponding link should've included the returnto parameter, and then the editor would automatically be taken to the item after logging in/creating an account.

Notes
Please replicate this on Special:NewLexeme page as well so that it works across both item pages and special pages.

Details

Subject	Repo	Branch	Lines +/-
Add returnto parameter to anonymous editor warning login link	mediawiki/extensions/Wikibase	master	+3 -2
anonymouseditwarning: params for links to login and create account	mediawiki/extensions/Wikibase	master	+2 -2
Use full title for special page returnto URLs	mediawiki/extensions/Wikibase	master	+5 -5
Bump special-new-lexeme to add returnto params for anon edit warning	mediawiki/extensions/WikibaseLexeme	master	+4 -4
Add anon edit warning link parameters	mediawiki/extensions/WikibaseLexeme	master	+12 -2
Fix AnonymousEditWarningBuilderTest on non-English wikis	mediawiki/extensions/Wikibase	master	+1 -1
Add anon edit warning link parameters	mediawiki/extensions/Wikibase	master	+108 -28

Customize query in gerrit

Related Objects

Mentioned Here: T343979: IP address warning on Lexeme editing page

Event Timeline

Logan created this task.Feb 25 2023, 5:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2023, 5:27 AM

Lydia_Pintscher added a project: good first task.Apr 6 2023, 10:27 AM

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.

Lydia_Pintscher added a subscriber: ItamarWMDE.

Change 910719 had a related patch set uploaded (by EpicPupper; author: EpicPupper):

[mediawiki/extensions/Wikibase@master] Add returnto parameter to anonymous editor warning login link

https://gerrit.wikimedia.org/r/910719

gerritbot added a project: Patch-For-Review.Apr 22 2023, 7:22 PM

Thank you for the patch! We will review it.

Lydia_Pintscher moved this task from Incoming to Unified DOT Backlog on the Wikidata Dev Team board.Apr 23 2023, 10:55 AM

karapayneWMDE moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.May 2 2023, 10:03 AM

karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.

ItamarWMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.May 3 2023, 8:22 AM

karapayneWMDE set the point value for this task to 1.May 16 2023, 10:02 AM

ItamarWMDE moved this task from Todo/Backlog to Parents/Waiting on the Wikidata Dev Team (Sprint-∞) board.May 16 2023, 1:22 PM

guergana.tzatchkova moved this task from Parents/Waiting to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Jun 9 2023, 1:33 PM

Based on what we found during review, I think this should be moved out of our sprint, and probably also no longer have the good first task tag. It’s not impossible to implement (the best approach is probably to build the full URL with returnto parameter in PHP and JS, then pass it as a parameter into the message), but it’s not as simple as we initially thought.

Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team; removed Wikidata Dev Team (Sprint-∞), good first task.Jul 7 2023, 10:49 AM

karapayneWMDE moved this task from Incoming to Unified DOT Backlog on the Wikidata Dev Team board.Jul 18 2023, 2:04 PM

karapayneWMDE removed a project: Patch-For-Review.Jul 24 2023, 2:12 PM

karapayneWMDE removed the point value for this task.

karapayneWMDE moved this task from Unified DOT Backlog to Product Backlog on the Wikidata Dev Team board.

Arian_Bozorg updated the task description. (Show Details)Aug 16 2023, 8:58 AM

karapayneWMDE moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Aug 16 2023, 9:37 AM

In T330550#8979978, @Lucas_Werkmeister_WMDE wrote:

Based on what we found during review, I think this should be moved out of our sprint, and probably also no longer have the good first task tag. It’s not impossible to implement (the best approach is probably to build the full URL with returnto parameter in PHP and JS, then pass it as a parameter into the message), but it’s not as simple as we initially thought.

Looking into this a bit too, I agree with Lucas. This would be the files directly affected by modifying that message, there are uses in Wikibase and WikibaseLexeme: https://codesearch.wmcloud.org/things/?q=wikibase-anonymouseditwarning&files=.*%5C.%28php%7Cjs%7Cts%29%24&excludeFiles=&repos=

The new Termbox already has the required returnto parameters. The respective warning in EntitySchema is very simple and does not include links.

WMDE-leszek set the point value for this task to 8.Aug 22 2023, 9:25 AM

WMDE-leszek moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.

WMDE-leszek edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.

Lucas_Werkmeister_WMDE moved this task from Peer Review to Parents/Waiting on the Wikidata Dev Team (Sprint-∞) board.Aug 22 2023, 3:14 PM

Task breakdown notes:

A codesearch on the URL to paramterize would be a good place to start: https://codesearch.wmcloud.org/things/?q=wikibase-anonymouseditwarning&files=.*%5C.%28php%7Cjs%7Cts%29%24&excludeFiles=&repos=
The comment in T343979#9112829 might add additional insight on where to start

ItamarWMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Aug 23 2023, 10:25 AM

Michael claimed this task.Sep 6 2023, 7:36 AM

Michael moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.

Restricted Application added a project: User-Michael. · View Herald TranscriptSep 6 2023, 7:36 AM

Michael removed Michael as the assignee of this task.Sep 6 2023, 8:38 AM

Michael moved this task from Doing to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.

Change 955689 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Add anon edit warning link parameters

https://gerrit.wikimedia.org/r/955689

Change 955690 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Add anon edit warning link parameters

https://gerrit.wikimedia.org/r/955690

Change 955691 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] anonymouseditwarning: params for links to login and create account

https://gerrit.wikimedia.org/r/955691

Michael claimed this task.Sep 7 2023, 2:31 PM

Michael moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.

This special-new-lexeme PR is ready for review: https://github.com/wmde/new-lexeme-special-page/pull/517

Change 957754 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Bump special-new-lexeme to add returnto params for anon edit warning

https://gerrit.wikimedia.org/r/957754

The GitHub PR has been merged, all other changes are ready for review on Gerrit.

Change 955690 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add anon edit warning link parameters

https://gerrit.wikimedia.org/r/955690

Change 957950 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Fix AnonymousEditWarningBuilderTest on non-English wikis

https://gerrit.wikimedia.org/r/957950

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 15 2023, 3:00 PM

Change 957950 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix AnonymousEditWarningBuilderTest on non-English wikis

https://gerrit.wikimedia.org/r/957950

Change 955689 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add anon edit warning link parameters

https://gerrit.wikimedia.org/r/955689

Change 957958 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use full title for special page returnto URLs

https://gerrit.wikimedia.org/r/957958

Change 957754 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Bump special-new-lexeme to add returnto params for anon edit warning

https://gerrit.wikimedia.org/r/957754

Change 957958 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use full title for special page returnto URLs

https://gerrit.wikimedia.org/r/957958

Change 955691 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] anonymouseditwarning: params for links to login and create account

https://gerrit.wikimedia.org/r/955691

Can now be reviewed on beta wikidata.

This looks good to me :)

Thanks so much

Change 910719 abandoned by Lucas Werkmeister (WMDE):