Page MenuHomePhabricator
Create Task
Maniphest T332636

Logging in to CopyPatrol doesn't always work first time
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
More often than not, CopyPatrol will load for a while and then refresh. You will not be logged in.

What should have happened instead?:
The page reloads and you are logged in

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Trying again after this failure normally works.
  • Not errors appear in the logs.
  • Reported on en.wikipedia

Related Objects
Search...

Event Timeline

TheresNoTime created this task.Mar 20 2023, 8:28 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptMar 20 2023, 8:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
JJMC89 moved this task from Backlog to Front end on the CopyPatrol board.Mar 20 2023, 8:30 PM
MusikAnimal mentioned this in T332349: Wikipedia Library /oauth/callback/ Permission denied.Mar 20 2023, 11:14 PM
MusikAnimal subscribed.EditedMar 20 2023, 11:44 PM

I spent several hours debugging this and finally concluded it's something with MediaWiki-extensions-OAuth itself that's failing. I've filed T332650: Frequent OAuth failures on Wikimedia wikis since eqiad was repooled due to db-mainstash replication lag.

CopyPatrol is supposed to show an error, but there's apparently an unrelated issue with flash messages not showing. I'm debugging that now.

TheresNoTime awarded a token.Mar 21 2023, 8:53 AM
TheresNoTime added a comment.Mar 22 2023, 2:37 PM
In T332636#8712334, @MusikAnimal wrote:

I spent several hours debugging this and finally concluded it's something with MediaWiki-extensions-OAuth itself that's failing. I've filed T332650: Frequent OAuth failures on Wikimedia wikis since eqiad was repooled due to db-mainstash replication lag.

CopyPatrol is supposed to show an error, but there's apparently an unrelated issue with flash messages not showing. I'm debugging that now.

Nice debugging by the way! 👏

MusikAnimal mentioned this in T332806: Flash messages aren't showing.Mar 22 2023, 5:51 PM
MusikAnimal added a subtask: T332650: Frequent OAuth failures on Wikimedia wikis since eqiad was repooled due to db-mainstash replication lag.Mar 22 2023, 5:54 PM
MusikAnimal edited projects, added Community-Tech (CommTech-Sprint-42); removed Community-Tech.
MusikAnimal set the point value for this task to 5.

Moving to the sprint since I spent so much time debugging this! I figure some points should go towards our velocity.

I think this will get resolved by the subtask T332650, but I'll keep this task open anyway until that is resolved. We may also be looking into switching to OAuth 2.0 which could make things simpler. If there's work involved there, it can be bundled in with this task.

The mystery with flash messages not showing is a separate problem. I've filed T332806 for that.

MusikAnimal claimed this task.Mar 22 2023, 5:55 PM
MusikAnimal moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-42) board.
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech (CommTech-Sprint-42), CopyPatrol.Mar 27 2023, 3:45 PM
• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.Mar 27 2023, 3:54 PM
• JMcLeod_WMF added a project: CopyPatrol.Mar 27 2023, 4:20 PM
MusikAnimal mentioned this in T333595: Request for arwiki to be added to CopyPatrol.Apr 3 2023, 5:45 PM
Ahmed_M_Farrag subscribed.Apr 3 2023, 8:19 PM
• Tgr closed subtask T332650: Frequent OAuth failures on Wikimedia wikis since eqiad was repooled due to db-mainstash replication lag as Resolved.Apr 14 2023, 9:01 AM
matmarex closed this task as Resolved.Apr 14 2023, 4:21 PM
matmarex subscribed.

Presumably resolved by the fix in the subtask. Please reopen if you still see the problem.

MusikAnimal moved this task from In Development 💻 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.Apr 15 2023, 5:26 PM

Indeed, no QA or anything needed here. Login is functioning normally again \o/

MusikAnimal moved this task from Front end to Done on the CopyPatrol board.Sep 2 2023, 3:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits