Maniphest T337148

Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Umherirrender
	May 20 2023, 8:28 PM

Tags

Referenced Files

None

Subscribers

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

AllLabelsFieldTest with provideFieldData
DescriptionFieldTest with getFieldDataProvider
abstract WikibaseNumericFieldTestCase with getFieldDataProvider
LabelsFieldTest with getFieldDataProvider
StatementQuantityFieldTest with statementsProvider

static and adjust the usages (More infos at T332865).

Initial work was done in bd214aeaafd6b16f227b11eb2bd6348894d900c7

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T255792 Quibble runs core:unit tests twice!
		Öffnen Sie		None	T328919 Upgrade to PHPUnit 10
		Öffnen Sie		None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
		Öffnen Sie		None	T332865 PHPUnit data providers should be simple static functions that return plain data
		Öffnen Sie		None	T371467 [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
		Öffnen Sie		None	T337148 Make PHPUnit dataProvider static in WikibaseCirrusSearch tests

Event Timeline

Umherirrender created this task.May 20 2023, 8:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2023, 8:28 PM

Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.May 20 2023, 8:28 PM

Umherirrender updated the task description. (Show Details)May 20 2023, 8:33 PM

• Lucas_Werkmeister_WMDE added a project: [DEPRECATED] wdwb-tech.May 30 2023, 11:26 AM

Umherirrender updated the task description. (Show Details)May 30 2023, 7:35 PM

Umherirrender unsubscribed.Jul 12 2023, 8:42 PM

• Lucas_Werkmeister_WMDE mentioned this in T371467: [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions.Jul 31 2024, 10:24 AM

• Lucas_Werkmeister_WMDE edited parent tasks, added: T371467: [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions; removed: T332865: PHPUnit data providers should be simple static functions that return plain data.