Page MenuHomePhabricator

[EPIC] Determine guidelines/recommendation for sizing of form components
Open, Needs TriagePublic

Description

Background

In T333392 we've included the large size in the Codex Button.

This task is about determining what the approach/recommendation should be for component sizing.

Pending that decision, we will consider if a Large size should be added for the rest of the form elements where buttons are used. That is, if the following components will need to be medium and large sizes:

  • Button T333392
  • ToggleButton
  • ButtonGroup and ToggleButtonGroup
  • TextInput
  • Select
  • Combobox

User stories

  • As a user I need buttons and form items to be the same size when placed next to each other.

Previous implementations

Design proposal

Include it here once it's done.

Design spec

Once a component spec sheet has been created in Figma, remove the note stating that the spec is missing and link to the spec below.

Component spec sheet

Open questions

Add here the questions to be answered in order to design and implement the component

Acceptance criteria (or Done)

  • Determine guidelines/recommendations for resizing components with medium/large size (relates to T338163)

Design

  • Design the Figma spec/specs and add it in this task
  • Update the component/components in the Figma library. This step will be done by a DST member.
    • Button T333392
    • ToggleButton
    • ButtonGroup and ToggleButtonGroup
    • TextInput
    • Select
    • Combobox

Code

  • Update the components in Codex:
    • Button T333392
    • ToggleButton
    • ButtonGroup and ToggleButtonGroup
    • TextInput
    • Select
    • Combobox

Future tasks

Event Timeline

@AnneT I've flagged some important components in which we should also include the large size to unify with the Button large, including ToggleButton (that is also a button) and ButtonGroup or ToggleButtonGroup.

RHo renamed this task from Add Large size in Buttons and Form items to Determine guidelines/recommendation for resizing form components.Jun 20 2023, 9:15 PM
RHo updated the task description. (Show Details)
RHo renamed this task from Determine guidelines/recommendation for resizing form components to Determine guidelines/recommendation for sizing of form components.Jun 22 2023, 4:07 PM

Decision from DST Design meeting today is that @Sarai-WMDE will first work on a task about how to handle responsiveness of components first, as that will help inform the work on this task.

I mentioned this in this week's meeting, but I figured I'd share here as well.

I think that most users will expect any size props for components to change the relative size of a component on the page across all breakpoints: a large button would be larger than a standard one at both mobile and desktop screen sizes, etc. This is how most other component libraries work (see Bootstrap button, input, and card sizing options for example – if you resize the page, the size of all components will change but the relative difference between different large oder small versions remains).

If we want to make it possible for a user to override the responsive behavior for a specific component, we may want to consider using a different prop name for this purpose.

CCiufo-WMF renamed this task from Determine guidelines/recommendation for sizing of form components to [BLOCKED] Determine guidelines/recommendation for sizing of form components.Jul 25 2023, 2:47 PM
CCiufo-WMF lowered the priority of this task from High to Medium.Sep 14 2023, 5:59 PM

There are many other use cases as well documented on T327426

CCiufo-WMF renamed this task from [BLOCKED] Determine guidelines/recommendation for sizing of form components to Determine guidelines/recommendation for sizing of form components.Mar 8 2024, 5:24 PM
CCiufo-WMF renamed this task from Determine guidelines/recommendation for sizing of form components to [EPIC] Determine guidelines/recommendation for sizing of form components.
CCiufo-WMF raised the priority of this task from Medium to Needs Triage.
CCiufo-WMF added a project: Design.