TextArea: remove error styles when readonly
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	lwatson
	Jun 9 2023, 2:13 PM

Description

Übersicht

We should remove the error styles when TextArea is readonly.

Both readonly and disabled prevent the user from typing in the <textarea>. Having an error status and being unable to edit the <textarea> would create a poor user experience.

Acceptance Criteria

users should not see error styles ( red border color ) when textarea is readonly

Ressourcen

CSS psuedo-class :not()

Details

	Subject	Repo	Branch	Lines +/-
	Update Codex from v0.12.0 to v0.13.0	mediawiki/core	master	+2 K -1 K
	TextArea: Remove error styles from readonly	design/codex	main	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		lwatson	T284272 TextArea: Add TextArea component to Codex
		Resolved		lwatson	T338616 TextArea: remove error styles when readonly

Event Timeline

lwatson created this task.Jun 9 2023, 2:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2023, 2:13 PM

@bmartinezcalvo thank you for bringing this to my attention!

lwatson moved this task from Inbox to Backlog on the Design-System-Team board.Jun 9 2023, 2:47 PM

Change 929350 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] TextArea: Remove error styles from readonly

https://gerrit.wikimedia.org/r/929350

gerritbot added a project: Patch-For-Review.Jun 12 2023, 2:40 PM

lwatson updated the task description. (Show Details)Jun 12 2023, 2:46 PM

lwatson edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.

lwatson updated the task description. (Show Details)

Restricted Application triaged this task as High priority. · View Herald TranscriptJun 12 2023, 2:48 PM

lwatson claimed this task.Jun 12 2023, 2:49 PM

lwatson moved this task from Committed to Code Review on the Design-System-Team (Design-System-Sprint) board.

lwatson renamed this task from TextArea: remove error styles from readonly to TextArea: remove error styles when readonly.Jun 12 2023, 3:22 PM

ldelench_wmf edited projects, added Design-System-Team; removed Design-System-Team (Design-System-Sprint).Jun 12 2023, 4:17 PM

ldelench_wmf moved this task from Backlog to Up Next on the Design-System-Team board.

Change 929350 merged by jenkins-bot:

[design/codex@main] TextArea: Remove error styles from readonly

https://gerrit.wikimedia.org/r/929350

AnneT edited projects, added Design-System-Team (Design-Systems-Sprint-1); removed Design-System-Team.Jun 12 2023, 6:56 PM

AnneT moved this task from Committed to Design Sign-Off on the Design-System-Team (Design-Systems-Sprint-1) board.

Maintenance_bot removed a project: Patch-For-Review.Jun 12 2023, 7:11 PM

ldelench_wmf set the point value for this task to 1.Jun 12 2023, 9:14 PM

lwatson closed this task as Resolved.Jun 13 2023, 12:46 AM

Change 931666 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.12.0 to v0.13.0

https://gerrit.wikimedia.org/r/931666

gerritbot added a project: Patch-For-Review.Jun 20 2023, 5:59 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/2c8b23bc31/w

Change 931666 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.12.0 to v0.13.0

https://gerrit.wikimedia.org/r/931666

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 20 2023, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2023, 7:11 PM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/2c8b23bc31/w/~~

TextArea: remove error styles when readonlyClosed, ResolvedPublic1 Estimated Story PointsActions