Page MenuHomePhabricator

Special:UserRights should not list autopromote groups for temporary users
Closed, ResolvedPublic

Description

This is for T330816: [Epic] Temporary users should not be assigned to user groups. See also T330816#8958447.

In rMWd6a3b6cfa8f5: TempUser EditPage and permissions, autopromotion was disabled for temporary users, at least via PermissionManager::getUserPermissions, which checks UserGroupManager::getUserEffectiveGroups, which calls PermissionManager::getUserImplicitGroups, which no longer checks autopromote groups for temporary users.

However, UserGroupManager::getUserAutopromoteGroups does check autopromote groups for temporary users, leading to them being listed on Special:UserRights for a temporary user.

Related Objects

StatusSubtypeAssignedTask
OpenNone
StalledNone
In ProgressNiharika
OpenNone
OpenTchanders
OpenNone
ResolvedSTran
ResolvedUmherirrender
Resolvedโ€ข AGueyte
Duplicateโ€ข AGueyte
ResolvedSTran
ResolvedDreamy_Jazz
ResolvedSTran
ResolvedSTran
OpenSTran
ResolvedSTran
ResolvedSTran
Resolvedkostajh
StalledNone
ResolvedTchanders
ResolvedSTran
OpenSTran
StalledNone
OpenNone
ResolvedSTran
ResolvedBUG REPORTDreamy_Jazz
OpenNone
Resolvedโ€ข TThoabala
Resolvedโ€ข TThoabala
Resolvedโ€ข TThoabala
Resolvedโ€ข AGueyte
ResolvedBUG REPORTโ€ข AGueyte
ResolvedBUG REPORTโ€ข AGueyte
Resolvedโ€ข AGueyte
Resolvedโ€ข AGueyte
ResolvedCyndymediawiksim
DuplicateNone
OpenNone
ResolvedTchanders
ResolvedTchanders

Event Timeline

Change 933491 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Don't report temporary users as belonging to autopromote groups

https://gerrit.wikimedia.org/r/933491

Testing notes

This is easiest to test locally, since it relies on specific configuration.

Create an autopromote group

Set something like the following configuration:

$wgAutopromote = [
	'editedonce' => [
		'&',
		[ APCOND_EDITCOUNT, 1 ],
	],
];

This creates a group called 'editedonce', which users get autopromoted to after editing 1 time.

Check groups on Special:UserRights

  • Create a new temporary user by editing
  • Visit Special:UserRights/<the temp user's name>
  • Before this task, they would be reported as belonging to the group 'editedonce'. After it, they shouldn't.

Change 933491 merged by jenkins-bot:

[mediawiki/core@master] Don't report temporary users as belonging to autopromote groups

https://gerrit.wikimedia.org/r/933491

dom_walden subscribed.

I confirmed the testing steps from T340462#8974248 locally (except I used the API to look up what groups the temp user belonged to, as Special:UserRights cannot be used with temp users since T340468).

Test environment: local MediaWiki 1.41.0-alpha (9a384e7) 11:21, 3 July 2023.