Maniphest T343464

Text in other language should have lang and dir attribute
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bugreporter
	Aug 3 2023, 2:21 PM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

Reproduce:

View https://www.wikifunctions.org/wiki/Z1001
Click "2 languages"
Open browser console and select the Arabic label
You will find there is no lang and dir attribute on the <span> or parent <div>
Click the label to edit it
There is no lang and dir attribute on the edit field either

Details

	Subject	Repo	Branch	Lines +/-
	Add dir and lang to HTML elements that differ from global uselang	mediawiki/extensions/WikiLambda	master	+929 -710

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		gengh	T363383 [24Q4] Wikifunctions's UX drives user behavior to increase linguistic accessibility
		Resolved		gengh	T343464 Text in other language should have lang and dir attribute

Event Timeline

Bugreporter created this task.Aug 3 2023, 2:21 PM

Bugreporter mentioned this in T343473: Labels should not be converted into Title Case.Aug 6 2023, 9:23 AM

Like T342661, this probably depends on T296882.

Jdforrester-WMF triaged this task as Medium priority.Aug 24 2023, 4:49 PM

Jdforrester-WMF moved this task from To triage to Needs Product/Design on the Abstract Wikipedia team board.

Nikki subscribed.Jan 8 2024, 7:28 PM

DVrandecic moved this task from Needs Product/Design to Upcoming Epics on the Abstract Wikipedia team board.Mar 21 2024, 5:08 PM

gengh claimed this task.May 14 2024, 3:32 PM

Jdforrester-WMF changed the task status from Open to In Progress.May 14 2024, 3:43 PM

Jdforrester-WMF added a parent task: T363383: [24Q4] Wikifunctions's UX drives user behavior to increase linguistic accessibility.

Jdforrester-WMF moved this task from Upcoming Epics to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.

Jdforrester-WMF edited projects, added Abstract Wikipedia team (24Q4 (Apr–Jun)); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to In Progress on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.

Change #1032417 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Add dir and lang to HTML elements that differ from global uselang

https://gerrit.wikimedia.org/r/1032417

gerritbot added a project: Patch-For-Review.May 16 2024, 10:47 AM

Change #1032417 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add dir and lang to HTML elements that differ from global uselang

https://gerrit.wikimedia.org/r/1032417

Jdforrester-WMF moved this task from In Progress to Ready to deploy on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.May 22 2024, 7:30 PM

Maintenance_bot removed a project: Patch-For-Review.May 22 2024, 7:31 PM

Jdforrester-WMF closed this task as Resolved.May 30 2024, 1:31 PM

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.

Jdforrester-WMF added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).