Maniphest T344297

Update LoginNotify to use the new HookContainer/HookRunner system
Closed, ResolvedPublic
Actions

Description

Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md for documentation.

Create HookRunner class and the hook handler interfaces
Use hook handlers
- core
- Echo (T315938)

Details

	Subject	Repo	Branch	Lines +/-
	Use HookHandlers for Echo hook	mediawiki/extensions/LoginNotify	master	+104 -91
	Use HookHandlers for core hooks	mediawiki/extensions/LoginNotify	master	+17 -6

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Umherirrender	T335536 Hard deprecate class Hooks with all deprecated functions (and remove in 1.42)
		Open		None	T254670 [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system
		Open		None	T263353 Update all Wikimedia production extensions to use the new HookContainer/HookRunner system
		Open		None	T263364 Update all tarballed extensions to use the new HookContainer/HookRunner system
		Resolved		Umherirrender	T344297 Update LoginNotify to use the new HookContainer/HookRunner system

Event Timeline

Umherirrender created this task.Aug 15 2023, 10:33 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptAug 15 2023, 10:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

HookRunner created with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/LoginNotify/+/927273/

Umherirrender updated the task description. (Show Details)Aug 15 2023, 10:33 PM

Umherirrender added parent tasks: T263364: Update all tarballed extensions to use the new HookContainer/HookRunner system, T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system.

Change 949069 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LoginNotify@master] Use HookHandlers for core hooks

https://gerrit.wikimedia.org/r/949069

Change 949127 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LoginNotify@master] Use HookHandlers for Echo hook

https://gerrit.wikimedia.org/r/949127

Change 949069 merged by jenkins-bot:

[mediawiki/extensions/LoginNotify@master] Use HookHandlers for core hooks

https://gerrit.wikimedia.org/r/949069

Umherirrender mentioned this in rELGNf02ff3ab3661: Use HookHandlers for core hooks.Aug 16 2023, 1:23 AM

Umherirrender updated the task description. (Show Details)Aug 16 2023, 1:26 AM

Change 949127 merged by jenkins-bot:

[mediawiki/extensions/LoginNotify@master] Use HookHandlers for Echo hook

https://gerrit.wikimedia.org/r/949127

Umherirrender mentioned this in rELGN4edd893fcc8a: Use HookHandlers for Echo hook.Aug 16 2023, 5:27 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2023, 5:30 AM

Umherirrender closed this task as Resolved.Aug 16 2023, 6:37 AM

Umherirrender claimed this task.

Umherirrender updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 5:10 PM