Page MenuHomePhabricator
Create Task
Maniphest T347391

Don't show ReferencePreviews together with Navigation Popups Footnote Previews
Closed, ResolvedPublic
Actions

Description

The Navigation-Popups-Gadget also supports the preview of references/footnotes. When it is used together with the Reference Previews feature from the Page-Previews (Popups) extension, it shows two popups when hovering a reference.

References NavPopups.png (210×716 px, 71 KB)

This should not happen. I guess we should disable Reference Previews automatically when we detect, that the user uses Navigation-Popups-Gadget . Similar to what we do when we detect that the user uses the reference tooltips gadget.

Note, that there's already a generic hint on the preferences page where you can toggle the Reference Previews feature, that informs about the possibility that gadgets might conflict.
Note, that in T267846: Investigation: Using ReferencePreviews together with NavigationPopups we did not consider this, because there the whole extension was disabled when the Navigation-Popups-Gadget was enabled. Now that's different.

Details

SubjectRepoBranchLines +/-
Disable reference previews when the navigation popups gadget is usedmediawiki/extensions/Popupsmaster+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Sep 26 2023, 12:09 PM
Restricted Application added subscribers: Enterprisey, Aklapper. · View Herald TranscriptSep 26 2023, 12:09 PM
WMDE-Fisch claimed this task.Sep 26 2023, 12:41 PM
WMDE-Fisch moved this task from Backlog to Doing on the WMDE-TechWish-Maintenance-2023 board.
thiemowmde attached a referenced file: F37766843: References NavPopups.png. (Show Details)Sep 26 2023, 12:43 PM
gerritbot added a comment.Sep 26 2023, 12:45 PM

Change 961098 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Popups@master] Disable reference previews when the navigation popups gadget is used

https://gerrit.wikimedia.org/r/961098

gerritbot added a project: Patch-For-Review.Sep 26 2023, 12:45 PM
WMDE-Fisch mentioned this in T345833: ReferencePreviews: Final round of manual tests before full rollout.Sep 26 2023, 12:48 PM
thiemowmde subscribed.Sep 26 2023, 1:01 PM

The Popups code already knows if the gadget is enabled and automatically disables Page-Previews then. I think we can simply use the existing flag and disable Reference Previews as well:

isReferencePreviewsEnabled.js
-       if ( config.get( 'wgPopupsConflictsWithRefTooltipsGadget' ) ||
+       if ( config.get( 'wgPopupsConflictsWithRefTooltipsGadget' ) ||
+               config.get( 'wgPopupsConflictsWithNavPopupGadget' ) ||

That should be it.

Note that the two gadgets also have self-disabling behavior. ReferenceTooltips turns itself off when NavigationPopups is enabled.

WMDE-Fisch moved this task from Doing to Review on the WMDE-TechWish-Maintenance-2023 board.Sep 26 2023, 1:18 PM
gerritbot added a comment.Sep 26 2023, 3:01 PM

Change 961098 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Disable reference previews when the navigation popups gadget is used

https://gerrit.wikimedia.org/r/961098

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2023, 3:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.29; 2023-10-03).Sep 26 2023, 4:00 PM
WMDE-Fisch moved this task from Review to Done on the WMDE-TechWish-Maintenance-2023 board.Sep 27 2023, 5:57 AM
Tobi_WMDE_SW closed this task as Resolved.Sep 27 2023, 12:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits