Page MenuHomePhabricator
Create Task
Maniphest T356934

Allow a user to perform global blocks on accounts using Special:GlobalBlock
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Dreamy_Jazz
Authored By
Dreamy_Jazz
Feb 7 2024, 10:27 PM
Tags
Referenced Files
F54810160: image.png
Jun 1 2024, 5:04 AM
F54810137: image.png
Jun 1 2024, 5:04 AM
F54810095: image.png
Jun 1 2024, 5:04 AM
F54810067: image.png
Jun 1 2024, 5:04 AM
F54809954: image.png
Jun 1 2024, 5:04 AM
F54809947: image.png
Jun 1 2024, 5:04 AM
F54807999: image.png
Jun 1 2024, 5:04 AM
F54807991: image.png
Jun 1 2024, 5:04 AM
View All 14 Files
Subscribers
Aklapper
Anterdc99
Djackson-ctr
Dreamy_Jazz
JaydenKieran

Description

Special:GlobalBlock allows a user to apply new and modify existing global blocks.

This special page should support applying and modifying global blocks for accounts.

Details

SubjectRepoBranchLines +/-
Update Special:GlobalBlock for account blocksmediawiki/extensions/GlobalBlockingmaster+286 -12
Expand tests for SpecialGlobalBlockmediawiki/extensions/GlobalBlockingmaster+156 -0
Partially update SpecialGlobalBlock for global account blocksmediawiki/extensions/GlobalBlockingmaster+170 -41
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 StalledNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 In ProgressNiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 Update features for temporary accounts
 OpenNoneT355286 [Epic] Globally blocking a temporary account should prevent further account creations
 OpenNoneT368949 Implement global autoblocks from global user blocks
 OpenNoneT19929 CentralAuth account locks should trigger global autoblocks
 DuplicateNoneT340275 Allow GlobalBlocking to block temporary accounts
 OpenFeatureDreamy_JazzT17294 Allow globally blocking of accounts
 OpenNoneT358777 Rename messages with the '-new' suffix to remove this suffix
 OpenDreamy_JazzT358776 Remove old versions of GlobalBlocking i18n messages
 OpenDreamy_JazzT358773 Remove the global accounts block configuration flag
 ResolvedDreamy_JazzT356924 Deploy global account blocks to WMF wikis
 ResolvedDreamy_JazzT356934 Allow a user to perform global blocks on accounts using Special:GlobalBlock
 ResolvedDreamy_JazzT356936 Update GlobalBlocking services to support global block on accounts
 ResolvedDreamy_JazzT358150 Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
 ResolvedDreamy_JazzT358157 Update the GlobalBlockManager service to support global blocks on accounts
 ResolvedDreamy_JazzT358155 Update GlobalBlockLookup service to support global blocks on accounts
 ResolvedDreamy_JazzT356876 Add a column to store central ID in globalblocks and global_block_whitelist tables
 Resolved• MarosteguiT356987 Add gb_target_central_id to the globalblocks table on the centralauth DB
 Resolved• MarosteguiT356988 Add gbw_target_central_id to global_block_whitelist table on WMF wikis
 ResolvedDreamy_JazzT356922 Deprecate unnecessary GlobalBlocking hooks
 ResolvedDreamy_JazzT359091 Create GlobalBlockLocalStatusManager service
 ResolvedDreamy_JazzT358865 Use non-legacy log parameters for log entries for global blocking and unblocking
 ResolvedDreamy_JazzT358725 Update the GlobalBlockingLinkBuilder service for global account blocks
 ResolvedDreamy_JazzT356923 Create a configuration value to control whether global account blocks are enabled
 ResolvedDreamy_JazzT356925 Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts
 ResolvedDreamy_JazzT357385 Refactor the GlobalBlocking utility class into services
 ResolvedDreamy_JazzT357399 Create GlobalBlockingConnectionProvider
 ResolvedDreamy_JazzT357443 Create GlobalBlockingBlockPurger service
 ResolvedDreamy_JazzT357506 Create GlobalBlockLocalStatusLookup service
 ResolvedDreamy_JazzT357675 Create GlobalBlockLookup service
 ResolvedDreamy_JazzT357925 Create the GlobalBlockManager service
 ResolvedBUG REPORTDreamy_JazzT366352 The "Locally block anonymous users only" checkbox is not properly disabled when it is made visible

Event Timeline

Dreamy_Jazz created this task.Feb 7 2024, 10:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2024, 10:27 PM
Dreamy_Jazz added a parent task: T356924: Deploy global account blocks to WMF wikis.Feb 7 2024, 10:27 PM
Dreamy_Jazz added a subtask: T356936: Update GlobalBlocking services to support global block on accounts.Feb 7 2024, 10:34 PM
gerritbot added a comment.Feb 27 2024, 11:54 AM

Change 1005816 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [Very WIP] Update GlobalBlockManager for global account blocks

https://gerrit.wikimedia.org/r/1005816

gerritbot added a project: Patch-For-Review.Feb 27 2024, 11:54 AM
Dreamy_Jazz claimed this task.Feb 27 2024, 11:55 AM
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)).
Dreamy_Jazz set the point value for this task to 2.Feb 28 2024, 10:20 PM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.
gerritbot added a comment.Mar 1 2024, 6:12 PM

Change 1007954 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Update Special:GlobalBlock for account blocks

https://gerrit.wikimedia.org/r/1007954

gerritbot added a comment.Mar 8 2024, 5:12 PM

Change 1009780 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Partially SpecialGlobalBlock for global account blocks

https://gerrit.wikimedia.org/r/1009780

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)); removed Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)).Mar 11 2024, 3:31 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.
gerritbot added a comment.Mar 18 2024, 6:08 PM

Change 1009780 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Partially update SpecialGlobalBlock for global account blocks

https://gerrit.wikimedia.org/r/1009780

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 18 2024, 7:00 PM
Dreamy_Jazz moved this task from Needs review to Priority Backlog on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 20 2024, 11:22 AM
Dreamy_Jazz removed a project: Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)).Mar 25 2024, 5:53 PM
Dreamy_Jazz closed subtask T356936: Update GlobalBlocking services to support global block on accounts as Resolved.Mar 27 2024, 9:40 AM
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).May 20 2024, 8:34 PM
gerritbot added a comment.May 20 2024, 10:16 PM

Change #1034187 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Expand tests for SpecialGlobalBlock

https://gerrit.wikimedia.org/r/1034187

Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 21 2024, 2:01 PM
gerritbot added a comment.May 21 2024, 4:04 PM

Change #1034187 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Expand tests for SpecialGlobalBlock

https://gerrit.wikimedia.org/r/1034187

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 21 2024, 5:00 PM
Dreamy_Jazz mentioned this in T364800: [[MediaWiki:Globalblocking-block-anononly-on-account/en]] confusing wording.May 23 2024, 3:48 PM
JaydenKieran subscribed.May 28 2024, 11:06 PM
Anterdc99 subscribed.May 29 2024, 1:33 AM
gerritbot added a comment.May 29 2024, 6:09 PM

Change #1007954 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update Special:GlobalBlock for account blocks

https://gerrit.wikimedia.org/r/1007954

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.8; 2024-06-04); removed MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 29 2024, 7:00 PM
Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 30 2024, 3:19 PM
Dreamy_Jazz added a comment.EditedMay 31 2024, 12:57 PM

Suggested QA steps, which can be performed on betawikis and/or patch demo and/or local wiki:

  1. Log into an account with the steward group
  2. Open Special:GlobalBlock
  3. Use that form to globally block IP and IP range, blocking at least one of these targets with the Globally block anonymous users only checkbox checked.
  4. Verify that these blocks appear in Special:GlobalBlockList after they are performed
  5. Open Special:GlobalBlock again
  6. Use the form to globally block a registered user account, verifying that the Globally block anonymous users only checkbox is disabled if a username is in the target field.
  7. Verify that the account block appears in Special:GlobalBlockList after they are performed
  8. Open Special:GlobalBlock again
  9. Test globally blocking an IP, IP range, and user target while the Also block the given user locally on this wiki checkbox is checked. Verify that the Locally block anonymous users only checkbox is disabled if the target is an account
  10. Verify that the local block is applied by checking it appears in Special:BlockList

You may also wish to test blocking temporary accounts and ensuring that the behaviour of the form is the same as for a normal user account.

One issue I found while writing the QA steps for this has been described at T366352: The "Locally block anonymous users only" checkbox is not properly disabled when it is made visible, and so can safely be ignored. This would affect step 9, where if you don't change the text inside the target input the Locally block anonymous users only checkbox may not be disabled.

Dreamy_Jazz added a subtask: T366352: The "Locally block anonymous users only" checkbox is not properly disabled when it is made visible.May 31 2024, 3:36 PM
Djackson-ctr subscribed.Jun 1 2024, 5:04 AM

I have verified the new code has been implemented and is functioning and displaying as expected... Thank You @Dreamy_Jazz!!!

image.png (859×1 px, 100 KB)

image.png (719×1 px, 111 KB)

image.png (843×1 px, 105 KB)

image.png (722×1 px, 117 KB)

image.png (872×1 px, 110 KB)

image.png (766×1 px, 110 KB)

image.png (974×1 px, 135 KB)

image.png (968×1 px, 131 KB)

image.png (879×434 px, 235 KB)

image.png (455×929 px, 236 KB)

image.png (905×741 px, 106 KB)

image.png (905×741 px, 106 KB)

image.png (685×910 px, 108 KB)

image.png (671×952 px, 234 KB)

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.Jun 1 2024, 5:09 AM
Dreamy_Jazz closed this task as Resolved.Jun 3 2024, 10:08 AM
Dreamy_Jazz moved this task from Sprint Shekere (13th May - 24th May) to Sprint Melodica (Jun 3 - Jun 14) on the Trust and Safety Product Sprint board.
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)); removed Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)); removed Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)), Patch-For-Review.
Dreamy_Jazz closed subtask T366352: The "Locally block anonymous users only" checkbox is not properly disabled when it is made visible as Resolved.Jun 4 2024, 8:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits