Page MenuHomePhabricator

Fix dropdown arrows in Vector dark mode
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

Screenshot 2024-05-14 at 1.08.17 PM.png (104×562 px, 10 KB)

User story

As a dark mode user, I want the Vector interface to be accessible and have sufficient contrast

Acceptance criteria

  • All dropdown arrows in Vector are made to have the correct color contrast in dark mode

Communication criteria - does this need an announcement or discussion?

none

Developer notes

Consider using codex here for the dropdown arrow icon

Requirement

Ensure that the user dropdown menu arrow in the Vector interface has the correct color contrast in dark mode, making it accessible. The user must be logged in.

BDD

Feature: Dropdown Arrows Color Contrast in Dark Mode

  Scenario: Ensure correct color contrast for user dropdown menu arrow in dark mode
    Given the user is logged in
    And the user has enabled dark mode
    When the user views the user dropdown menu arrow in the Vector interface
    Then the dropdown arrow should have the correct color contrast
    And the arrow should be accessible

Test Steps

Test Case 1: Ensure Correct Color Contrast for User Dropdown Menu Arrow in Dark Mode

  1. Log in to Wikipedia.
  2. Enable dark mode in the Vector interface.
  3. Navigate to a page with the user dropdown menu arrow.
  4. AC1: Confirm that the user dropdown menu arrow has the correct color contrast and is accessible.

QA Results - Beta

ACStatusDetails
1T365035#9831910

QA Results - PROD

ACStatusDetails
1T365035#9857575

Event Timeline

Jdlrobson subscribed.

Change #1035591 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/Vector@master] Adds invert exception for dropdown

https://gerrit.wikimedia.org/r/1035591

Change #1035591 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Adds invert exception for dropdown

https://gerrit.wikimedia.org/r/1035591

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Correct Color Contrast for User Dropdown Menu Arrow in Dark Mode

  1. Log in to Wikipedia.
  2. Enable dark mode in the Vector interface.
  3. Navigate to a page with the user dropdown menu arrow.
  4. AC1: Confirm that the user dropdown menu arrow has the correct color contrast and is accessible.

screenshot 374.png (632×1 px, 217 KB)

Jdlrobson claimed this task.

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 125
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Correct Color Contrast for User Dropdown Menu Arrow in Dark Mode

  1. Log in to Wikipedia.
  2. Enable dark mode in the Vector interface.
  3. Navigate to a page with the user dropdown menu arrow.
  4. AC1: Confirm that the user dropdown menu arrow has the correct color contrast and is accessible.

2024-06-03_16-30-38.png (709×3 px, 462 KB)